cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Copy only expected arguments for constructor if statically sized.

Browse Source
This commit is contained in:
chriseth 2015-06-24 00:23:10 +02:00
parent fd1a01bbce
commit 2d169748b7
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Compiler.cpp
View File

@ -165,10 +165,26 @@ void Compiler::appendConstructor(FunctionDefinition const& _constructor)
// copy constructor arguments from code to memory and then to stack, they are supplied after the actual program // copy constructor arguments from code to memory and then to stack, they are supplied after the actual program
if (!_constructor.getParameters().empty()) if (!_constructor.getParameters().empty())
{ {
unsigned argumentSize = 0;
for (ASTPointer<VariableDeclaration> const& var: _constructor.getParameters())
if (var->getType()->isDynamicallySized())
{
argumentSize = 0;
break;
}
else
argumentSize += var->getType()->getCalldataEncodedSize();
CompilerUtils(m_context).fetchFreeMemoryPointer(); CompilerUtils(m_context).fetchFreeMemoryPointer();
m_context.appendProgramSize(); // program itself if (argumentSize == 0)
// CODESIZE is program plus manually added arguments {
m_context << eth::Instruction::CODESIZE << eth::Instruction::SUB; // argument size is dynamic, use CODESIZE to determine it
m_context.appendProgramSize(); // program itself
// CODESIZE is program plus manually added arguments
m_context << eth::Instruction::CODESIZE << eth::Instruction::SUB;
}
else
m_context << u256(argumentSize);
// stack: <memptr> <argument size> // stack: <memptr> <argument size>
m_context << eth::Instruction::DUP1; m_context << eth::Instruction::DUP1;
m_context.appendProgramSize(); m_context.appendProgramSize();