Merge pull request #5102 from ethereum/abiencoderv2-tests

Run all end-to-end tests with ABIEncoderV2

scripts/tests.sh

@@ -190,18 +190,33 @@ for optimize in "" "--optimize"
 do
   for vm in $EVM_VERSIONS
   do
-    printTask "--> Running tests using "$optimize" --evm-version "$vm"..."
+    FORCE_ABIV2_RUNS="no"
-    log=""
+    if [[ "$vm" == "constantinople" ]]
-    if [ -n "$log_directory" ]
     then
-      if [ -n "$optimize" ]
+      FORCE_ABIV2_RUNS="no yes" # run both in constantinople
-      then
-        log=--logger=JUNIT,test_suite,$log_directory/opt_$vm.xml $testargs
-      else
-        log=--logger=JUNIT,test_suite,$log_directory/noopt_$vm.xml $testargs_no_opt
-      fi
     fi
-    "$REPO_ROOT"/build/test/soltest $progress $log -- --testpath "$REPO_ROOT"/test "$optimize" --evm-version "$vm" $SMT_FLAGS $IPC_FLAGS  --ipcpath "${WORKDIR}/geth.ipc"
+    for abiv2 in $FORCE_ABIV2_RUNS
+    do
+        force_abiv2_flag=""
+        if [[ "$abiv2" == "yes" ]]
+        then
+            force_abiv2_flag="--abiencoderv2"
+        fi
+        printTask "--> Running tests using "$optimize" --evm-version "$vm" $force_abiv2_flag..."
+
+        log=""
+        if [ -n "$log_directory" ]
+        then
+        if [ -n "$optimize" ]
+        then
+            log=--logger=JUNIT,test_suite,$log_directory/opt_$vm.xml $testargs
+        else
+            log=--logger=JUNIT,test_suite,$log_directory/noopt_$vm.xml $testargs_no_opt
+        fi
+        fi
+
+        "$REPO_ROOT"/build/test/soltest $progress $log -- --testpath "$REPO_ROOT"/test "$optimize" --evm-version "$vm" $SMT_FLAGS $IPC_FLAGS $force_abiv2_flag --ipcpath "${WORKDIR}/geth.ipc"
+    done
   done
 done
 

test/Options.cpp

@@ -55,6 +55,8 @@ Options::Options()
 		}
 		else if (string(suite.argv[i]) == "--optimize")
 			optimize = true;
+		else if (string(suite.argv[i]) == "--abiencoderv2")
+			useABIEncoderV2 = true;
 		else if (string(suite.argv[i]) == "--evm-version")
 		{
 			evmVersionString = i + 1 < suite.argc ? suite.argv[i + 1] : "INVALID";

test/Options.h

@@ -41,6 +41,7 @@ struct Options: boost::noncopyable
 	bool optimize = false;
 	bool disableIPC = false;
 	bool disableSMT = false;
+	bool useABIEncoderV2 = false;
 
 	void validate() const;
 	solidity::EVMVersion evmVersion() const;

test/libsolidity/ABIDecoderTests.cpp

@@ -86,7 +86,7 @@ BOOST_AUTO_TEST_CASE(enums)
 			}
 		}
 	)";
-	bool newDecoder = false;
+	bool newDecoder = dev::test::Options::get().useABIEncoderV2;
 	BOTH_ENCODERS(
 		compileAndRun(sourceCode);
 		ABI_CHECK(callContractFunction("f(uint8)", 0), encodeArgs(u256(0)));

test/libsolidity/ABIEncoderTests.cpp

@@ -164,10 +164,13 @@ BOOST_AUTO_TEST_CASE(memory_array_one_dim)
 		}
 	)";
 
-	compileAndRun(sourceCode);
+	if (!dev::test::Options::get().useABIEncoderV2)
-	callContractFunction("f()");
+	{
-	// The old encoder does not clean array elements.
+		compileAndRun(sourceCode);
-	REQUIRE_LOG_DATA(encodeArgs(10, 0x60, 11, 3, u256("0xfffffffe"), u256("0xffffffff"), u256("0x100000000")));
+		callContractFunction("f()");
+		// The old encoder does not clean array elements.
+		REQUIRE_LOG_DATA(encodeArgs(10, 0x60, 11, 3, u256("0xfffffffe"), u256("0xffffffff"), u256("0x100000000")));
+	}
 
 	compileAndRun(NewEncoderPragma + sourceCode);
 	callContractFunction("f()");

test/libsolidity/GasCosts.cpp

@@ -70,6 +70,9 @@ BOOST_AUTO_TEST_CASE(string_storage)
 
 	if (Options::get().evmVersion() <= EVMVersion::byzantium())
 		CHECK_GAS(134435, 130591, 100);
+	// This is only correct on >=Constantinople.
+	else if (Options::get().useABIEncoderV2)
+		CHECK_GAS(151819, 142753, 100);
 	else
 		CHECK_GAS(127225, 124873, 100);
 	if (Options::get().evmVersion() >= EVMVersion::byzantium())
@@ -77,6 +80,9 @@ BOOST_AUTO_TEST_CASE(string_storage)
 		callContractFunction("f()");
 		if (Options::get().evmVersion() == EVMVersion::byzantium())
 			CHECK_GAS(21551, 21526, 20);
+		// This is only correct on >=Constantinople.
+		else if (Options::get().useABIEncoderV2)
+			CHECK_GAS(21713, 21635, 20);
 		else
 			CHECK_GAS(21546, 21526, 20);
 	}

test/libsolidity/GasMeter.cpp

@@ -73,9 +73,14 @@ public:
 		// costs for transaction
 		gas += gasForTransaction(m_compiler.object(m_compiler.lastContractName()).bytecode, true);
 
-		BOOST_REQUIRE(!gas.isInfinite);
+		// Skip the tests when we force ABIEncoderV2.
-		BOOST_CHECK_LE(m_gasUsed, gas.value);
+		// TODO: We should enable this again once the yul optimizer is activated.
-		BOOST_CHECK_LE(gas.value - _tolerance, m_gasUsed);
+		if (!dev::test::Options::get().useABIEncoderV2)
+		{
+			BOOST_REQUIRE(!gas.isInfinite);
+			BOOST_CHECK_LE(m_gasUsed, gas.value);
+			BOOST_CHECK_LE(gas.value - _tolerance, m_gasUsed);
+		}
 	}
 
 	/// Compares the gas computed by PathGasMeter for the given signature (but unknown arguments)
@@ -97,9 +102,14 @@ public:
 			*m_compiler.runtimeAssemblyItems(m_compiler.lastContractName()),
 			_sig
 		);
-		BOOST_REQUIRE(!gas.isInfinite);
+		// Skip the tests when we force ABIEncoderV2.
-		BOOST_CHECK_LE(m_gasUsed, gas.value);
+		// TODO: We should enable this again once the yul optimizer is activated.
-		BOOST_CHECK_LE(gas.value - _tolerance, m_gasUsed);
+		if (!dev::test::Options::get().useABIEncoderV2)
+		{
+			BOOST_REQUIRE(!gas.isInfinite);
+			BOOST_CHECK_LE(m_gasUsed, gas.value);
+			BOOST_CHECK_LE(gas.value - _tolerance, m_gasUsed);
+		}
 	}
 
 	static GasMeter::GasConsumption gasForTransaction(bytes const& _data, bool _isCreation)

test/libsolidity/SolidityEndToEndTest.cpp

@@ -14317,12 +14317,17 @@ BOOST_AUTO_TEST_CASE(abi_encode_empty_string)
 			}
 		}
 	)";
+
 	compileAndRun(sourceCode, 0, "C");
-	ABI_CHECK(callContractFunction("f()"), encodeArgs(
+	if (!dev::test::Options::get().useABIEncoderV2)
-		0x40, 0xc0,
+	{
-		0x60, 0x20, 0x00, 0x00,
+		// ABI Encoder V2 has slightly different padding, tested below.
-		0x00
+		ABI_CHECK(callContractFunction("f()"), encodeArgs(
-	));
+			0x40, 0xc0,
+			0x60, 0x20, 0x00, 0x00,
+			0x00
+		));
+	}
 }
 
 BOOST_AUTO_TEST_CASE(abi_encode_empty_string_v2)

test/libsolidity/SolidityExecutionFramework.h

@@ -65,7 +65,10 @@ public:
 	)
 	{
 		// Silence compiler version warning
-		std::string sourceCode = "pragma solidity >=0.0;\n" + _sourceCode;
+		std::string sourceCode = "pragma solidity >=0.0;\n";
+		if (dev::test::Options::get().useABIEncoderV2 && _sourceCode.find("pragma experimental ABIEncoderV2;") == std::string::npos)
+			sourceCode += "pragma experimental ABIEncoderV2;\n";
+		sourceCode += _sourceCode;
 		m_compiler.reset(false);
 		m_compiler.addSource("", sourceCode);
 		m_compiler.setLibraries(_libraryAddresses);