cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Only warn about unused return in low-level functions.

Browse Source
This commit is contained in:
chriseth 2016-06-24 16:41:17 +02:00
parent cc6314cd01
commit 25a64c7f8f
2 changed files with 64 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
libsolidity/analysis/TypeChecker.cpp
View File

@ -831,12 +831,21 @@ void TypeChecker::endVisit(ExpressionStatement const& _statement)
if (!dynamic_cast<RationalNumberType const&>(*type(_statement.expression())).mobileType()) if (!dynamic_cast<RationalNumberType const&>(*type(_statement.expression())).mobileType())
typeError(_statement.expression().location(), "Invalid rational number."); typeError(_statement.expression().location(), "Invalid rational number.");
bool unusedReturnValue = true; if (auto call = dynamic_cast<FunctionCall const*>(&_statement.expression()))
if (auto t = dynamic_cast<TupleType const*>(type(_statement.expression()).get())) {
if (t->components().empty()) if (auto callType = dynamic_cast<FunctionType const*>(type(call->expression()).get()))
unusedReturnValue = false; {
if (unusedReturnValue) using Location = FunctionType::Location;
warning(_statement.location(), "Unused return value."); Location location = callType->location();
if (
location == Location::Bare ||
location == Location::BareCallCode ||
location == Location::BareDelegateCall ||
location == Location::Send
)
warning(_statement.location(), "Return value of low-level calls not used.");
}
}
} }
bool TypeChecker::visit(Conditional const& _conditional) bool TypeChecker::visit(Conditional const& _conditional)

50
test/libsolidity/SolidityNameAndTypeResolution.cpp
View File

@ -3760,7 +3760,7 @@ BOOST_AUTO_TEST_CASE(unused_return_value)
} }
} }
)"; )";
BOOST_CHECK(expectError(text, true) == Error::Type::Warning); BOOST_CHECK(success(text));
} }
BOOST_AUTO_TEST_CASE(unused_return_value_send) BOOST_AUTO_TEST_CASE(unused_return_value_send)
@ -3775,6 +3775,54 @@ BOOST_AUTO_TEST_CASE(unused_return_value_send)
BOOST_CHECK(expectError(text, true) == Error::Type::Warning); BOOST_CHECK(expectError(text, true) == Error::Type::Warning);
} }
BOOST_AUTO_TEST_CASE(unused_return_value_call)
{
char const* text = R"(
contract test {
function f() {
address(0x12).call("abc");
}
}
)";
BOOST_CHECK(expectError(text, true) == Error::Type::Warning);
}
BOOST_AUTO_TEST_CASE(unused_return_value_call_value)
{
char const* text = R"(
contract test {
function f() {
address(0x12).call.value(2)("abc");
}
}
)";
BOOST_CHECK(expectError(text, true) == Error::Type::Warning);
}
BOOST_AUTO_TEST_CASE(unused_return_value_callcode)
{
char const* text = R"(
contract test {
function f() {
address(0x12).callcode("abc");
}
}
)";
BOOST_CHECK(expectError(text, true) == Error::Type::Warning);
}
BOOST_AUTO_TEST_CASE(unused_return_value_delegatecall)
{
char const* text = R"(
contract test {
function f() {
address(0x12).delegatecall("abc");
}
}
)";
BOOST_CHECK(expectError(text, true) == Error::Type::Warning);
}
BOOST_AUTO_TEST_SUITE_END() BOOST_AUTO_TEST_SUITE_END()
} }