cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #3941 from ethereum/bytes-contract

Browse Source 
Disallow explicit conversion of bytesXX to contract
This commit is contained in:
chriseth 2018-04-19 16:10:15 +02:00 committed by GitHub
commit 2546a274ca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -9,6 +9,7 @@ Bugfixes:
* Type Checker: Improve error message for failed function overload resolution. * Type Checker: Improve error message for failed function overload resolution.
* Type Checker: Do not complain about new-style constructor and fallback function to have the same name. * Type Checker: Do not complain about new-style constructor and fallback function to have the same name.
* Type Checker: Detect multiple constructor declarations in the new syntax and old syntax. * Type Checker: Detect multiple constructor declarations in the new syntax and old syntax.
* Type Checker: Explicit conversion of ``bytesXX`` to ``contract`` is properly disallowed.
### 0.4.22 (2018-04-16) ### 0.4.22 (2018-04-16)

1
libsolidity/ast/Types.cpp
View File

@ -1299,7 +1299,6 @@ bool FixedBytesType::isExplicitlyConvertibleTo(Type const& _convertTo) const
{ {
return _convertTo.category() == Category::Integer || return _convertTo.category() == Category::Integer ||
_convertTo.category() == Category::FixedPoint || _convertTo.category() == Category::FixedPoint ||
_convertTo.category() == Category::Contract ||
_convertTo.category() == category(); _convertTo.category() == category();
} }

7
test/libsolidity/syntaxTests/types/bytes_to_contract.sol Normal file
View File

@ -0,0 +1,7 @@
contract C {
function f() public pure {
C(bytes20(0x1234));
}
}
// ----
// TypeError: (64-82): Explicit type conversion not allowed from "bytes20" to "contract C".