Changelog entry and tests.

This commit is contained in:
chriseth 2018-11-22 17:28:02 +01:00
parent 4d7799eed4
commit 1e7a23a205
3 changed files with 12 additions and 1 deletions

View File

@ -3,7 +3,6 @@
Language Features: Language Features:
* Allow public functions to override external functions. * Allow public functions to override external functions.
Compiler Features: Compiler Features:
* Build System: LLL is not built anymore by default. Must configure it with CMake as `-DLLL=ON`. * Build System: LLL is not built anymore by default. Must configure it with CMake as `-DLLL=ON`.
* Code generator: Do not perform redundant double cleanup on unsigned integers when loading from calldata. * Code generator: Do not perform redundant double cleanup on unsigned integers when loading from calldata.
@ -16,6 +15,7 @@ Compiler Features:
Bugfixes: Bugfixes:
* Assembly output: Do not mix in/out jump annotations with arguments. * Assembly output: Do not mix in/out jump annotations with arguments.
* Code Generator: Annotate jump from calldata decoder to function as "jump in". * Code Generator: Annotate jump from calldata decoder to function as "jump in".
* Type Checker: Properly detect different return types when overriding an external interface function with a public contract function.
Build System: Build System:
* Emscripten: Upgrade to Emscripten SDK 1.37.21 and boost 1.67. * Emscripten: Upgrade to Emscripten SDK 1.37.21 and boost 1.67.

View File

@ -0,0 +1,10 @@
interface I {
function f() external pure returns (uint);
}
contract B is I {
// The compiler used to have a bug where changing
// the return type was fine in this situation.
function f() public pure returns (uint, uint) {}
}
// ----
// TypeError: (182-230): Overriding function return types differ.

View File

@ -4,3 +4,4 @@ contract C {
} }
// ---- // ----
// DeclarationError: (17-66): Function with same name and arguments defined twice. // DeclarationError: (17-66): Function with same name and arguments defined twice.
// TypeError: (17-66): Overriding function return types differ.