cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Raise error when using unimplemented internal library functions.

Browse Source
This commit is contained in:
Alex Beregszaszi
2017-08-08 11:58:00 +01:00
parent bea37e5682
commit 1ada48f61e
3 changed files with 40 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libsolidity/analysis/TypeChecker.cpp
+15
View File
@@ -1403,6 +1403,21 @@ bool TypeChecker::visit(FunctionCall const& _functionCall)
else
_functionCall.annotation().type = make_shared<TupleType>(functionType->returnParameterTypes());
// Internal library functions must be implemented, because of inlining rules.
if (
functionType->kind() == FunctionType::Kind::Internal &&
functionType->hasDeclaration() &&
dynamic_cast<FunctionDefinition const*>(&functionType->declaration())
)
{
FunctionDefinition const* function = dynamic_cast<FunctionDefinition const*>(&functionType->declaration());
bool isLibraryFunction =
dynamic_cast<ContractDefinition const*>(function->scope()) &&
dynamic_cast<ContractDefinition const*>(function->scope())->isLibrary();
if (!function->isImplemented() && isLibraryFunction)
m_errorReporter.typeError(_functionCall.location(), "Inlined library function is lacking implementation.");
}
TypePointers parameterTypes = functionType->parameterTypes();
if (!functionType->takesArbitraryParameters() && parameterTypes.size() != arguments.size())
{