cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Only suggest removing parentheses from a construction call if they're empty

Browse Source
This commit is contained in:
Kamil Śliwak 2023-02-13 20:25:19 +01:00
parent 73183d3df9
commit 1a981af548
7 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libsolidity/analysis/TypeChecker.cpp
View File

@ -365,7 +365,7 @@ void TypeChecker::endVisit(InheritanceSpecifier const& _inheritance)
toString(arguments->size()) + toString(arguments->size()) +
" arguments given but expected " + " arguments given but expected " +
toString(parameterTypes.size()) + toString(parameterTypes.size()) +
". Remove parentheses if you do not want to provide arguments here." (arguments->size() == 0 ? ". Remove parentheses if you do not want to provide arguments here." : "")
); );
} }
for (size_t i = 0; i < std::min(arguments->size(), parameterTypes.size()); ++i) for (size_t i = 0; i < std::min(arguments->size(), parameterTypes.size()); ++i)

4
test/libsolidity/syntaxTests/constructor/base_constructor_wrong_arg_count_inheritance_and_modifier_lists.sol
View File

@ -7,7 +7,7 @@ contract E is C(1) { constructor() C(1) {} }
// ---- // ----
// DeclarationError 3364: (93-108): Base constructor arguments given twice. // DeclarationError 3364: (93-108): Base constructor arguments given twice.
// DeclarationError 3364: (149-153): Base constructor arguments given twice. // DeclarationError 3364: (149-153): Base constructor arguments given twice.
// TypeError 7927: (61-76): Wrong argument count for constructor call: 3 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (61-76): Wrong argument count for constructor call: 3 arguments given but expected 2
// TypeError 2973: (93-108): Wrong argument count for modifier invocation: 3 arguments given but expected 2. // TypeError 2973: (93-108): Wrong argument count for modifier invocation: 3 arguments given but expected 2.
// TypeError 7927: (128-132): Wrong argument count for constructor call: 1 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (128-132): Wrong argument count for constructor call: 1 arguments given but expected 2
// TypeError 2973: (149-153): Wrong argument count for modifier invocation: 1 arguments given but expected 2. // TypeError 2973: (149-153): Wrong argument count for modifier invocation: 1 arguments given but expected 2.

4
test/libsolidity/syntaxTests/constructor/base_constructor_wrong_arg_count_inheritance_list.sol
View File

@ -5,5 +5,5 @@ contract C {
contract D is C(1, true, "a") {} contract D is C(1, true, "a") {}
contract E is C(1) {} contract E is C(1) {}
// ---- // ----
// TypeError 7927: (61-76): Wrong argument count for constructor call: 3 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (61-76): Wrong argument count for constructor call: 3 arguments given but expected 2
// TypeError 7927: (94-98): Wrong argument count for constructor call: 1 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (94-98): Wrong argument count for constructor call: 1 arguments given but expected 2

4
test/libsolidity/syntaxTests/constructor/base_constructor_wrong_arg_count_inheritance_list_abstract.sol
View File

@ -5,5 +5,5 @@ abstract contract C {
abstract contract D is C(1, true, "a") {} abstract contract D is C(1, true, "a") {}
abstract contract E is C(1) {} abstract contract E is C(1) {}
// ---- // ----
// TypeError 7927: (79-94): Wrong argument count for constructor call: 3 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (79-94): Wrong argument count for constructor call: 3 arguments given but expected 2
// TypeError 7927: (121-125): Wrong argument count for constructor call: 1 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (121-125): Wrong argument count for constructor call: 1 arguments given but expected 2

4
test/libsolidity/syntaxTests/constructor/base_constructor_wrong_arg_count_inheritance_list_with_derived_constructor.sol
View File

@ -5,5 +5,5 @@ contract C {
contract D is C(1, true, "a") { constructor() {} } contract D is C(1, true, "a") { constructor() {} }
contract E is C(1) { constructor() {} } contract E is C(1) { constructor() {} }
// ---- // ----
// TypeError 7927: (61-76): Wrong argument count for constructor call: 3 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (61-76): Wrong argument count for constructor call: 3 arguments given but expected 2
// TypeError 7927: (112-116): Wrong argument count for constructor call: 1 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (112-116): Wrong argument count for constructor call: 1 arguments given but expected 2

2
test/libsolidity/syntaxTests/inheritance/too_few_base_arguments.sol
View File

@ -6,5 +6,5 @@ contract Derived2 is Base {
constructor() Base(2) { } constructor() Base(2) { }
} }
// ---- // ----
// TypeError 7927: (67-74): Wrong argument count for constructor call: 1 arguments given but expected 2. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (67-74): Wrong argument count for constructor call: 1 arguments given but expected 2
// TypeError 2973: (123-130): Wrong argument count for modifier invocation: 1 arguments given but expected 2. // TypeError 2973: (123-130): Wrong argument count for modifier invocation: 1 arguments given but expected 2.

2
test/libsolidity/syntaxTests/nameAndTypeResolution/525_reject_interface_constructors.sol
View File

@ -1,4 +1,4 @@
interface I {} interface I {}
contract C is I(2) {} contract C is I(2) {}
// ---- // ----
// TypeError 7927: (29-33): Wrong argument count for constructor call: 1 arguments given but expected 0. Remove parentheses if you do not want to provide arguments here. // TypeError 7927: (29-33): Wrong argument count for constructor call: 1 arguments given but expected 0