cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tone down error message.

Browse Source
This commit is contained in:
chriseth 2017-08-31 16:14:54 +02:00
parent 7886c24d40
commit 1a1db1ec96
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libsolidity/analysis/ViewPureChecker.cpp
View File

@ -215,13 +215,13 @@ void ViewPureChecker::reportMutability(StateMutability _mutability, SourceLocati
string text;
if (_mutability == StateMutability::View)
text =
"Function declared as pure, but this expression reads from the "
"Function declared as pure, but this expression (potentially) reads from the "
"environment or state and thus requires \"view\".";
else if (_mutability == StateMutability::NonPayable)
text =
"Function declared as " +
stateMutabilityToString(m_currentFunction->stateMutability()) +
", but this expression modifies the state and thus "
", but this expression (potentially) modifies the state and thus "
"requires non-payable (the default) or payable.";
else
solAssert(false, "");

6
test/libsolidity/ViewPureChecker.cpp
View File

@ -88,7 +88,7 @@ BOOST_AUTO_TEST_CASE(call_internal_functions_fail)
CHECK_ERROR(
"contract C{ function f() pure { g(); } function g() view {} }",
TypeError,
"Function declared as pure, but this expression reads from the environment or state and thus requires \"view\""
"Function declared as pure, but this expression (potentially) reads from the environment or state and thus requires \"view\""
);
}
@ -96,7 +96,7 @@ BOOST_AUTO_TEST_CASE(write_storage_fail)
{
CHECK_WARNING(
"contract C{ uint x; function f() view { x = 2; } }",
"Function declared as view, but this expression modifies the state and thus requires non-payable (the default) or payable."
"Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable."
);
}
@ -131,7 +131,7 @@ BOOST_AUTO_TEST_CASE(environment_access)
CHECK_ERROR(
"contract C { function f() pure { var x = " + x + "; x; } }",
TypeError,
"Function declared as pure, but this expression reads from the environment or state and thus requires \"view\""
"Function declared as pure, but this expression (potentially) reads from the environment or state and thus requires \"view\""
);
}
for (string const& x: pure)