cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #10006 from ethereum/bug-9229-fix

Browse Source 
Fixes internal compiler error with an unused reference to module member.
This commit is contained in:
chriseth 2020-10-12 13:43:35 +02:00 committed by GitHub
commit 1a125cf755
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -8,6 +8,7 @@ Compiler Features:
Bugfixes:
* Code generator: Fix internal compiler error when referencing members via module name but not using the reference.
* Type Checker: Fix internal compiler error caused by storage parameters with nested mappings in libraries.
* Name Resolver: Fix shadowing/same-name warnings for later declarations.

5
libsolidity/codegen/ExpressionCompiler.cpp
View File

@ -1772,6 +1772,11 @@ bool ExpressionCompiler::visit(MemberAccess const& _memberAccess)
solAssert(*_memberAccess.annotation().requiredLookup == VirtualLookup::Static, "");
utils().pushCombinedFunctionEntryLabel(*function);
}
else if (auto const* contract = dynamic_cast<ContractDefinition const*>(_memberAccess.annotation().referencedDeclaration))
{
if (contract->isLibrary())
m_context.appendLibraryAddress(contract->fullyQualifiedName());
}
break;
}
default:

15
test/libsolidity/syntaxTests/memberLookup/unused_module_member_reference.sol Normal file
View File

@ -0,0 +1,15 @@
==== Source: s1.sol ====
import "s1.sol" as A;
library L {
function f() internal pure {}
}
contract C
{
function test() public pure {
A.L;
}
}
// ----
// Warning 6133: (s1.sol:127-130): Statement has no effect.