Rename and add anonymous namespace.

This commit is contained in:
chriseth 2017-09-01 19:58:38 +02:00
parent c83768c426
commit 15bdc48a73
3 changed files with 6 additions and 3 deletions

View File

@ -189,7 +189,7 @@ bool SemanticInformation::invalidatesStorage(Instruction _instruction)
} }
} }
bool SemanticInformation::invalidInPureFunctions(Instruction _instruction) bool SemanticInformation::readsFromState(Instruction _instruction)
{ {
switch (_instruction) switch (_instruction)
{ {

View File

@ -53,7 +53,7 @@ struct SemanticInformation
static bool invalidatesMemory(solidity::Instruction _instruction); static bool invalidatesMemory(solidity::Instruction _instruction);
/// @returns true if the given instruction modifies storage (even indirectly). /// @returns true if the given instruction modifies storage (even indirectly).
static bool invalidatesStorage(solidity::Instruction _instruction); static bool invalidatesStorage(solidity::Instruction _instruction);
static bool invalidInPureFunctions(solidity::Instruction _instruction); static bool readsFromState(solidity::Instruction _instruction);
static bool invalidInViewFunctions(solidity::Instruction _instruction); static bool invalidInViewFunctions(solidity::Instruction _instruction);
}; };

View File

@ -27,6 +27,8 @@ using namespace std;
using namespace dev; using namespace dev;
using namespace dev::solidity; using namespace dev::solidity;
namespace
{
class AssemblyViewPureChecker: public boost::static_visitor<void> class AssemblyViewPureChecker: public boost::static_visitor<void>
{ {
@ -39,7 +41,7 @@ public:
{ {
if (eth::SemanticInformation::invalidInViewFunctions(_instruction.instruction)) if (eth::SemanticInformation::invalidInViewFunctions(_instruction.instruction))
m_reportMutability(StateMutability::NonPayable, _instruction.location); m_reportMutability(StateMutability::NonPayable, _instruction.location);
else if (eth::SemanticInformation::invalidInPureFunctions(_instruction.instruction)) else if (eth::SemanticInformation::readsFromState(_instruction.instruction))
m_reportMutability(StateMutability::View, _instruction.location); m_reportMutability(StateMutability::View, _instruction.location);
} }
void operator()(assembly::Literal const&) {} void operator()(assembly::Literal const&) {}
@ -96,6 +98,7 @@ private:
std::function<void(StateMutability, SourceLocation const&)> m_reportMutability; std::function<void(StateMutability, SourceLocation const&)> m_reportMutability;
}; };
}
bool ViewPureChecker::check() bool ViewPureChecker::check()
{ {