cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[TMP] mantissaExponent(): Allow full uint range for exponent

Browse Source
This commit is contained in:
Kamil Śliwak 2022-07-12 15:37:06 +02:00
parent 4899b854d8
commit 155c93580f
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libsolidity/ast/Types.cpp
View File

@ -1230,18 +1230,15 @@ pair<RationalNumberType const*, RationalNumberType const*> RationalNumberType::m
bool negative = (m_value < 0); bool negative = (m_value < 0);
rational const maxMantissa = (negative ? -minInt : maxUint); rational const maxMantissa = (negative ? -minInt : maxUint);
int exponent = 0; rational exponent = 0;
rational unsignedMantissa = abs(m_value); rational unsignedMantissa = abs(m_value);
while (unsignedMantissa.denominator() != 1) while (unsignedMantissa.denominator() != 1)
{ {
unsignedMantissa *= 10; unsignedMantissa *= 10;
--exponent; --exponent;
if ( // FIXME: What happens when exponent in scientific notation is max uint?
unsignedMantissa > maxUint || if (unsignedMantissa > maxMantissa || exponent > maxUint)
unsignedMantissa < minInt ||
exponent < -255 // TODO: sane value?
)
return {nullptr, nullptr}; return {nullptr, nullptr};
} }