cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Allow enums in interfaces

Browse Source
This commit is contained in:
Alex Beregszaszi 2018-05-08 15:11:28 +01:00
parent 9d3827266c
commit 13e37df97c
4 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog.md
View File

@ -69,6 +69,7 @@ Language Features:
* General: Allow appending ``calldata`` keyword to types, to explicitly specify data location for arguments of external functions. * General: Allow appending ``calldata`` keyword to types, to explicitly specify data location for arguments of external functions.
* General: Support ``pop()`` for storage arrays. * General: Support ``pop()`` for storage arrays.
* General: Scoping rules now follow the C99-style. * General: Scoping rules now follow the C99-style.
* General: Allow ``enum``s in interfaces.
Compiler Features: Compiler Features:
* C API (``libsolc``): Export the ``solidity_license``, ``solidity_version`` and ``solidity_compile`` methods. * C API (``libsolc``): Export the ``solidity_license``, ``solidity_version`` and ``solidity_compile`` methods.

7
libsolidity/analysis/TypeChecker.cpp
View File

@ -751,13 +751,6 @@ bool TypeChecker::visit(VariableDeclaration const& _variable)
return false; return false;
} }
bool TypeChecker::visit(EnumDefinition const& _enum)
{
if (m_scope->contractKind() == ContractDefinition::ContractKind::Interface)
m_errorReporter.typeError(_enum.location(), "Enumerable cannot be declared in interfaces.");
return false;
}
void TypeChecker::visitManually( void TypeChecker::visitManually(
ModifierInvocation const& _modifier, ModifierInvocation const& _modifier,
vector<ContractDefinition const*> const& _bases vector<ContractDefinition const*> const& _bases

1
libsolidity/analysis/TypeChecker.h
View File

@ -96,7 +96,6 @@ private:
virtual bool visit(StructDefinition const& _struct) override; virtual bool visit(StructDefinition const& _struct) override;
virtual bool visit(FunctionDefinition const& _function) override; virtual bool visit(FunctionDefinition const& _function) override;
virtual bool visit(VariableDeclaration const& _variable) override; virtual bool visit(VariableDeclaration const& _variable) override;
virtual bool visit(EnumDefinition const& _enum) override;
/// We need to do this manually because we want to pass the bases of the current contract in /// We need to do this manually because we want to pass the bases of the current contract in
/// case this is a base constructor call. /// case this is a base constructor call.
void visitManually(ModifierInvocation const& _modifier, std::vector<ContractDefinition const*> const& _bases); void visitManually(ModifierInvocation const& _modifier, std::vector<ContractDefinition const*> const& _bases);

1
test/libsolidity/syntaxTests/nameAndTypeResolution/422_interface_enums.sol
View File

@ -2,4 +2,3 @@ interface I {
enum A { B, C } enum A { B, C }
} }
// ---- // ----
// TypeError: (18-33): Enumerable cannot be declared in interfaces.