cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Review fixes.

Browse Source
This commit is contained in:
chriseth 2022-11-30 10:21:02 +01:00
parent f5f3eaacb9
commit 135f965488
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
libyul/optimiser/KnowledgeBase.cpp
View File

@ -182,19 +182,26 @@ void KnowledgeBase::reset(YulString _var)
if (set<YulString>* group = util::valueOrNullptr(m_groupMembers, _var)) if (set<YulString>* group = util::valueOrNullptr(m_groupMembers, _var))
{ {
// _var was a representative, we might have to find a new one. // _var was a representative, we might have to find a new one.
if (group->empty()) if (!group->empty())
m_groupMembers.erase(_var);
else
{ {
YulString newRepresentative = *group->begin(); YulString newRepresentative = *group->begin();
yulAssert(newRepresentative != _var);
u256 newOffset = m_offsets[newRepresentative].offset; u256 newOffset = m_offsets[newRepresentative].offset;
// newOffset = newRepresentative - _var
for (YulString groupMember: *group) for (YulString groupMember: *group)
{ {
yulAssert(m_offsets[groupMember].reference == _var); yulAssert(m_offsets[groupMember].reference == _var);
m_offsets[groupMember].reference = newRepresentative; m_offsets[groupMember].reference = newRepresentative;
m_offsets[newRepresentative].offset -= newOffset; // groupMember = _var + m_offsets[groupMember].offset (old)
// = newRepresentative - newOffset + m_offsets[groupMember].offset (old)
// so subtracting newOffset from .offset yields the original relation again,
// just with _var replaced by newRepresentative
m_offsets[groupMember].offset -= newOffset;
} }
m_groupMembers[newRepresentative] = std::move(*group);
} }
m_groupMembers.erase(_var);
} }
} }