From 133bc729708d07ab4eb72fd9e00d817a294f0926 Mon Sep 17 00:00:00 2001
From: hrkrshnn <webmail.hari@gmail.com>
Date: Thu, 21 Jan 2021 20:28:35 +0100
Subject: [PATCH] Tests and changelog for <address>.code.length shortcut

---
 Changelog.md                                  |  1 +
 .../semanticTests/various/code_length.sol     | 64 +++++++++++++++++++
 .../various/code_length_contract_member.sol   | 17 +++++
 3 files changed, 82 insertions(+)
 create mode 100644 test/libsolidity/semanticTests/various/code_length.sol
 create mode 100644 test/libsolidity/semanticTests/various/code_length_contract_member.sol

diff --git a/Changelog.md b/Changelog.md
index 8e991f703..9b4826386 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -5,6 +5,7 @@ Language Features:
 
 Compiler Features:
  * Build system: Update the soljson.js build to emscripten 2.0.12 and boost 1.75.0.
+ * Code Generator: Reduce the cost of ``<address>.code.length`` by using ``extcodesize`` directly.
  * Command Line Interface: Allow "=" as separator between library name and address in ``--libraries`` commandline option.
  * Command Line Interface: New option ``--model-checker-targets`` allows specifying which targets should be checked. The valid options are ``all``, ``constantCondition``, ``underflow``, ``overflow``, ``divByZero``, ``balance``, ``assert``, ``popEmptyArray``, where the default is ``all``. Multiple targets can be chosen at the same time, separated by a comma without spaces: ``underflow,overflow,assert``.
  * Command Line Interface: Only accept the library address that is prefixed with "0x" in ``--libraries`` commandline option.
diff --git a/test/libsolidity/semanticTests/various/code_length.sol b/test/libsolidity/semanticTests/various/code_length.sol
new file mode 100644
index 000000000..a807933a6
--- /dev/null
+++ b/test/libsolidity/semanticTests/various/code_length.sol
@@ -0,0 +1,64 @@
+// SPDX-License-Identifier: GPL-3.0
+contract C {
+    uint len1;
+    uint len2;
+    constructor() {
+        uint mem_ptr_before;
+        uint mem_ptr_after;
+
+        assembly {
+            mem_ptr_before := mload(64)
+        }
+
+        len1 = address(0).code.length;
+
+        assembly {
+            mem_ptr_after := mload(64)
+        }
+
+        // To check that no memory was allocated and written.
+        assert(mem_ptr_before == mem_ptr_after);
+
+        len2 = address(this).code.length;
+
+        // To check that no memory was allocated and written.
+        assembly {
+            mem_ptr_after := mload(64)
+        }
+
+        assert(mem_ptr_before == mem_ptr_after);
+
+    }
+
+    function f() public view returns (bool r1, bool r2) {
+        uint mem_ptr_before;
+        uint mem_ptr_after;
+
+        assembly {
+            mem_ptr_before := mload(64)
+        }
+
+        r1 = address(this).code.length > 50;
+
+        assembly {
+            mem_ptr_after := mload(64)
+        }
+
+        // To check that no memory was allocated and written.
+        assert(mem_ptr_before == mem_ptr_after);
+
+        address a = address(0);
+        r2 = a.code.length == 0;
+
+        // To check that no memory was allocated and written.
+        assembly {
+            mem_ptr_after := mload(64)
+        }
+
+    }
+}
+// ====
+// compileViaYul: also
+// ----
+// constructor()
+// f(): true, true -> true, true
diff --git a/test/libsolidity/semanticTests/various/code_length_contract_member.sol b/test/libsolidity/semanticTests/various/code_length_contract_member.sol
new file mode 100644
index 000000000..a6184a318
--- /dev/null
+++ b/test/libsolidity/semanticTests/various/code_length_contract_member.sol
@@ -0,0 +1,17 @@
+// Test to see if type.code.length does extcodesize(type) only when type is an address.
+struct S {
+    bytes32 code;
+    bytes32 another;
+}
+
+contract C {
+    S s;
+
+    function f() public returns (uint, uint, bool) {
+        return (s.code.length, s.another.length, address(this).code.length > 50);
+    }
+}
+// ====
+// compileViaYul: also
+// ----
+// f() -> 0x20, 0x20, true