cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Display helpful warning for unused function arguments/return parameters

Browse Source
This commit is contained in:
Suman
2017-09-12 15:35:03 +01:00
committed by Alex Beregszaszi
parent f2412da800
commit 10d290cb9b
3 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/libsolidity/SolidityNameAndTypeResolution.cpp
+7 -7
View File
@@ -5816,7 +5816,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_local)
}
}
)";
CHECK_WARNING(text, "Unused");
CHECK_WARNING(text, "Unused local variable.");
}
BOOST_AUTO_TEST_CASE(warn_unused_local_assigned)
@@ -5828,10 +5828,10 @@ BOOST_AUTO_TEST_CASE(warn_unused_local_assigned)
}
}
)";
CHECK_WARNING(text, "Unused");
CHECK_WARNING(text, "Unused local variable.");
}
BOOST_AUTO_TEST_CASE(warn_unused_param)
BOOST_AUTO_TEST_CASE(warn_unused_function_parameter)
{
char const* text = R"(
contract C {
@@ -5839,7 +5839,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_param)
}
}
)";
CHECK_WARNING(text, "Unused");
CHECK_WARNING(text, "Unused function parameter. Remove or comment out the variable name to silence this warning.");
text = R"(
contract C {
function f(uint a) {
@@ -5849,7 +5849,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_param)
success(text);
}
BOOST_AUTO_TEST_CASE(warn_unused_return_param)
BOOST_AUTO_TEST_CASE(warn_unused_return_parameter)
{
char const* text = R"(
contract C {
@@ -5857,7 +5857,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_return_param)
}
}
)";
CHECK_WARNING(text, "Unused");
CHECK_WARNING(text, "Unused function parameter. Remove or comment out the variable name to silence this warning.");
text = R"(
contract C {
function f() returns (uint a) {
@@ -5865,7 +5865,7 @@ BOOST_AUTO_TEST_CASE(warn_unused_return_param)
}
}
)";
CHECK_WARNING(text, "Unused");
CHECK_WARNING(text, "Unused function parameter. Remove or comment out the variable name to silence this warning.");
text = R"(
contract C {
function f() returns (uint) {