cerc-io/solidity
11
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update code after review

Browse Source
This commit is contained in:
wechman
2022-06-07 11:54:22 +02:00
parent 4ed523c4e8
commit 0f55a4d671
4 changed files with 42 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libsolidity/analysis/TypeChecker.cpp
+6 -5
View File
@@ -68,8 +68,10 @@ bool TypeChecker::typeSupportedByOldABIEncoder(Type const& _type, bool _isLibrar
}
if (_type.category() == Type::Category::InlineArray)
{
auto const& inlineArray = dynamic_cast<InlineArrayType const&>(_type);
return typeSupportedByOldABIEncoder(*inlineArray.mobileType(), _isLibraryCall);
auto const& mobileType = dynamic_cast<InlineArrayType const&>(_type).mobileType();
if (!mobileType)
return false;
return typeSupportedByOldABIEncoder(*mobileType, _isLibraryCall);
}
return true;
}
@@ -1208,7 +1210,7 @@ void TypeChecker::endVisit(Return const& _return)
_return.expression()->location(),
"Return argument type " +
type(*_return.expression())->toString() +
" is not implicitly convertible to expected type " +
" is not implicitly convertible to expected type (type of first return variable) " +
TupleType(returnTypes).toString(false) + ".",
result.message()
);
@@ -3259,13 +3261,12 @@ bool TypeChecker::visit(IndexAccess const& _access)
}
case Type::Category::InlineArray:
{
InlineArrayType const& actualType = dynamic_cast<InlineArrayType const&>(*baseType);
if (!index)
m_errorReporter.typeError(5093_error, _access.location(), "Index expression cannot be omitted.");
else
expectType(*index, *TypeProvider::uint256());
resultType = actualType.componentsCommonMobileType();
resultType = dynamic_cast<InlineArrayType const&>(*baseType).componentsCommonMobileType();
break;
}
case Type::Category::Mapping: