From 0d2ae84081500168fb1596c2bc6198b3a67b86d6 Mon Sep 17 00:00:00 2001 From: chriseth Date: Thu, 4 Apr 2019 17:48:02 +0200 Subject: [PATCH] Use move semantics. --- libyul/AsmScope.cpp | 4 ++-- libyul/AsmScope.h | 4 ++-- libyul/AsmScopeFiller.cpp | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libyul/AsmScope.cpp b/libyul/AsmScope.cpp index b71f2367e..252361d27 100644 --- a/libyul/AsmScope.cpp +++ b/libyul/AsmScope.cpp @@ -42,11 +42,11 @@ bool Scope::registerVariable(YulString _name, YulType const& _type) return true; } -bool Scope::registerFunction(YulString _name, std::vector const& _arguments, std::vector const& _returns) +bool Scope::registerFunction(YulString _name, std::vector _arguments, std::vector _returns) { if (exists(_name)) return false; - identifiers[_name] = Function{_arguments, _returns}; + identifiers[_name] = Function{std::move(_arguments), std::move(_returns)}; return true; } diff --git a/libyul/AsmScope.h b/libyul/AsmScope.h index 2a8ef49e8..f6c7fe59a 100644 --- a/libyul/AsmScope.h +++ b/libyul/AsmScope.h @@ -56,8 +56,8 @@ struct Scope bool registerLabel(YulString _name); bool registerFunction( YulString _name, - std::vector const& _arguments, - std::vector const& _returns + std::vector _arguments, + std::vector _returns ); /// Looks up the identifier in this or super scopes and returns a valid pointer if found diff --git a/libyul/AsmScopeFiller.cpp b/libyul/AsmScopeFiller.cpp index 9156e7e02..1706b147d 100644 --- a/libyul/AsmScopeFiller.cpp +++ b/libyul/AsmScopeFiller.cpp @@ -170,7 +170,7 @@ bool ScopeFiller::registerFunction(FunctionDefinition const& _funDef) vector returns; for (auto const& _return: _funDef.returnVariables) returns.emplace_back(_return.type.str()); - if (!m_currentScope->registerFunction(_funDef.name, arguments, returns)) + if (!m_currentScope->registerFunction(_funDef.name, std::move(arguments), std::move(returns))) { //@TODO secondary location m_errorReporter.declarationError(