Merge pull request #4850 from anurag-git/anurag_issue_3667

Fix for Ensure that missed enum values are tested for in Types #3667
This commit is contained in:
chriseth 2018-09-03 16:39:37 +02:00 committed by GitHub
commit 0b9cc80bed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1501,8 +1501,6 @@ TypePointer ReferenceType::unaryOperatorResult(Token::Value _operator) const
return make_shared<TupleType>(); return make_shared<TupleType>();
case DataLocation::Storage: case DataLocation::Storage:
return m_isPointer ? TypePointer() : make_shared<TupleType>(); return m_isPointer ? TypePointer() : make_shared<TupleType>();
default:
solAssert(false, "");
} }
return TypePointer(); return TypePointer();
} }
@ -1548,8 +1546,6 @@ string ReferenceType::identifierLocationSuffix() const
case DataLocation::CallData: case DataLocation::CallData:
id += "_calldata"; id += "_calldata";
break; break;
default:
solAssert(false, "Unknown location returned by location()");
} }
if (isPointer()) if (isPointer())
id += "_ptr"; id += "_ptr";
@ -2556,7 +2552,6 @@ string FunctionType::richIdentifier() const
case Kind::ABIEncodeWithSelector: id += "abiencodewithselector"; break; case Kind::ABIEncodeWithSelector: id += "abiencodewithselector"; break;
case Kind::ABIEncodeWithSignature: id += "abiencodewithsignature"; break; case Kind::ABIEncodeWithSignature: id += "abiencodewithsignature"; break;
case Kind::ABIDecode: id += "abidecode"; break; case Kind::ABIDecode: id += "abidecode"; break;
default: solAssert(false, "Unknown function location."); break;
} }
id += "_" + stateMutabilityToString(m_stateMutability); id += "_" + stateMutabilityToString(m_stateMutability);
id += identifierList(m_parameterTypes) + "returns" + identifierList(m_returnParameterTypes); id += identifierList(m_parameterTypes) + "returns" + identifierList(m_returnParameterTypes);
@ -3257,8 +3252,6 @@ string MagicType::richIdentifier() const
return "t_magic_transaction"; return "t_magic_transaction";
case Kind::ABI: case Kind::ABI:
return "t_magic_abi"; return "t_magic_abi";
default:
solAssert(false, "Unknown kind of magic");
} }
return ""; return "";
} }