Merge pull request #7140 from ethereum/ci-binonic-gcc-7

fix PPA comp. error and add ubuntu:bionic gcc-7 to CI to test for it.
This commit is contained in:
Mathias L. Baumann 2019-07-30 11:16:41 +02:00 committed by GitHub
commit 092e62f1c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 2 deletions

View File

@ -233,6 +233,18 @@ jobs:
- store_artifacts: *artifacts_solc - store_artifacts: *artifacts_solc
- persist_to_workspace: *artifacts_executables - persist_to_workspace: *artifacts_executables
b_ubu18: &build_ubuntu1804
docker:
- image: ethereum/solidity-buildpack-deps:ubuntu1804
environment:
CMAKE_OPTIONS: -DCMAKE_CXX_FLAGS=-O2
CMAKE_BUILD_TYPE: RelWithDebugInfo
steps:
- checkout
- run: *run_build
- store_artifacts: *artifacts_solc
- persist_to_workspace: *artifacts_executables
b_ubu_codecov: b_ubu_codecov:
<<: *build_ubuntu1904 <<: *build_ubuntu1904
environment: environment:
@ -589,6 +601,7 @@ workflows:
# Ubuntu 18.10 build and tests # Ubuntu 18.10 build and tests
- b_ubu: *workflow_trigger_on_tags - b_ubu: *workflow_trigger_on_tags
- b_ubu18: *workflow_trigger_on_tags
- t_ubu_cli: *workflow_ubuntu1904 - t_ubu_cli: *workflow_ubuntu1904
- t_ubu_homestead: *workflow_ubuntu1904 - t_ubu_homestead: *workflow_ubuntu1904
- t_ubu_homestead_opt: *workflow_ubuntu1904 - t_ubu_homestead_opt: *workflow_ubuntu1904

View File

@ -922,7 +922,7 @@ string YulUtilFunctions::readFromCalldata(Type const& _type)
return readFromMemoryOrCalldata(_type, true); return readFromMemoryOrCalldata(_type, true);
} }
string YulUtilFunctions::updateStorageValueFunction(Type const& _type, boost::optional<unsigned> const _offset) string YulUtilFunctions::updateStorageValueFunction(Type const& _type, boost::optional<unsigned> const& _offset)
{ {
string const functionName = string const functionName =
"update_storage_value_" + "update_storage_value_" +

View File

@ -193,7 +193,7 @@ public:
/// the specified slot and offset. If offset is not given, it is expected as /// the specified slot and offset. If offset is not given, it is expected as
/// runtime parameter. /// runtime parameter.
/// signature: (slot, [offset,] value) /// signature: (slot, [offset,] value)
std::string updateStorageValueFunction(Type const& _type, boost::optional<unsigned> const _offset = boost::optional<unsigned>()); std::string updateStorageValueFunction(Type const& _type, boost::optional<unsigned> const& _offset = boost::optional<unsigned>());
/// Returns the name of a function that will write the given value to /// Returns the name of a function that will write the given value to
/// the specified address. /// the specified address.