Merge pull request #7140 from ethereum/ci-binonic-gcc-7

fix PPA comp. error and add ubuntu:bionic gcc-7 to CI to test for it.

.circleci/config.yml

@@ -233,6 +233,18 @@ jobs:
       - store_artifacts: *artifacts_solc
       - persist_to_workspace: *artifacts_executables
 
+  b_ubu18: &build_ubuntu1804
+    docker:
+      - image: ethereum/solidity-buildpack-deps:ubuntu1804
+    environment:
+      CMAKE_OPTIONS: -DCMAKE_CXX_FLAGS=-O2
+      CMAKE_BUILD_TYPE: RelWithDebugInfo
+    steps:
+      - checkout
+      - run: *run_build
+      - store_artifacts: *artifacts_solc
+      - persist_to_workspace: *artifacts_executables
+
   b_ubu_codecov:
     <<: *build_ubuntu1904
     environment:
@@ -589,6 +601,7 @@ workflows:
 
       # Ubuntu 18.10 build and tests
       - b_ubu: *workflow_trigger_on_tags
+      - b_ubu18: *workflow_trigger_on_tags
       - t_ubu_cli: *workflow_ubuntu1904
       - t_ubu_homestead: *workflow_ubuntu1904
       - t_ubu_homestead_opt: *workflow_ubuntu1904

libsolidity/codegen/YulUtilFunctions.cpp

@@ -922,7 +922,7 @@ string YulUtilFunctions::readFromCalldata(Type const& _type)
 	return readFromMemoryOrCalldata(_type, true);
 }
 
-string YulUtilFunctions::updateStorageValueFunction(Type const& _type, boost::optional<unsigned> const _offset)
+string YulUtilFunctions::updateStorageValueFunction(Type const& _type, boost::optional<unsigned> const& _offset)
 {
 	string const functionName =
 		"update_storage_value_" +

libsolidity/codegen/YulUtilFunctions.h

@@ -193,7 +193,7 @@ public:
 	/// the specified slot and offset. If offset is not given, it is expected as
 	/// runtime parameter.
 	/// signature: (slot, [offset,] value)
-	std::string updateStorageValueFunction(Type const& _type, boost::optional<unsigned> const _offset = boost::optional<unsigned>());
+	std::string updateStorageValueFunction(Type const& _type, boost::optional<unsigned> const& _offset = boost::optional<unsigned>());
 
 	/// Returns the name of a function that will write the given value to
 	/// the specified address.