cerc-io/solidity
16
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

WasmCodeTransform: Convert Yul 'if's with i32 argument directly to wasm 'if' without an extra comparison with zero

Browse Source
This commit is contained in:
Kamil Śliwak 2020-06-15 19:30:06 +02:00
parent 50b426e37b
commit 06e1b38d1d
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
libyul/backends/wasm/WasmCodeTransform.cpp
View File

@ -178,18 +178,23 @@ wasm::Expression WasmCodeTransform::operator()(Literal const& _literal)
wasm::Expression WasmCodeTransform::operator()(If const& _if) wasm::Expression WasmCodeTransform::operator()(If const& _if)
{ {
yul::Type conditionType = m_typeInfo.typeOf(*_if.condition); yul::Type conditionType = m_typeInfo.typeOf(*_if.condition);
YulString ne_instruction = YulString(conditionType.str() + ".ne");
yulAssert(WasmDialect::instance().builtin(ne_instruction), "");
// TODO converting i64 to i32 might not always be needed. wasm::Expression condition;
if (conditionType == "i32"_yulstring)
condition = visitReturnByValue(*_if.condition);
else if (conditionType == "i64"_yulstring)
{
vector<wasm::Expression> args; vector<wasm::Expression> args;
args.emplace_back(visitReturnByValue(*_if.condition)); args.emplace_back(visitReturnByValue(*_if.condition));
args.emplace_back(makeLiteral(translatedType(conditionType), 0)); args.emplace_back(makeLiteral(translatedType("i64"_yulstring), 0));
return wasm::If{
make_unique<wasm::Expression>(wasm::BuiltinCall{ne_instruction.str(), std::move(args)}), // NOTE: `if` in wasm requires an i32 argument
visit(_if.body.statements), condition = wasm::BuiltinCall{"i64.ne", std::move(args)};
{} }
}; else
yulAssert(false, "Invalid condition type");
return wasm::If{make_unique<wasm::Expression>(move(condition)), visit(_if.body.statements), {}};
} }
wasm::Expression WasmCodeTransform::operator()(Switch const& _switch) wasm::Expression WasmCodeTransform::operator()(Switch const& _switch)