cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added error message for virtual (library) functions; test case

Browse Source
This commit is contained in:
hrkrshnn 2020-04-03 13:26:57 +05:30
parent 3beaae6822
commit 042ccd24ab
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libsolidity/analysis/TypeChecker.cpp
View File

@ -332,6 +332,8 @@ bool TypeChecker::visit(FunctionDefinition const& _function)
m_errorReporter.warning(_function.location(), "Interface functions are implicitly \"virtual\""); m_errorReporter.warning(_function.location(), "Interface functions are implicitly \"virtual\"");
if (_function.visibility() == Visibility::Private) if (_function.visibility() == Visibility::Private)
m_errorReporter.typeError(_function.location(), "\"virtual\" and \"private\" cannot be used together."); m_errorReporter.typeError(_function.location(), "\"virtual\" and \"private\" cannot be used together.");
if (isLibraryFunction)
m_errorReporter.typeError(_function.location(), "Library functions cannot be \"virtual\".");
} }
if (_function.isPayable()) if (_function.isPayable())

5
test/libsolidity/syntaxTests/inheritance/virtual/library_err.sol Normal file
View File

@ -0,0 +1,5 @@
library L {
function f() internal pure virtual returns (uint) { return 0; }
}
// ----
// TypeError: (16-79): Library functions cannot be "virtual".