diff --git a/solc/CommandLineInterface.cpp b/solc/CommandLineInterface.cpp index d33b87a8f..3e3053ce0 100644 --- a/solc/CommandLineInterface.cpp +++ b/solc/CommandLineInterface.cpp @@ -22,28 +22,8 @@ */ #include "CommandLineInterface.h" -#ifdef _WIN32 // windows - #include - #define isatty _isatty - #define fileno _fileno -#else // unix - #include -#endif -#include -#include -#include - -#include -#include -#include - #include "solidity/BuildInfo.h" -#include -#include -#include -#include -#include -#include + #include #include #include @@ -54,9 +34,31 @@ #include #include #include -#include #include +#include +#include + +#include +#include +#include +#include + +#include +#include +#include + +#ifdef _WIN32 // windows + #include + #define isatty _isatty + #define fileno _fileno +#else // unix + #include +#endif +#include +#include +#include + using namespace std; namespace po = boost::program_options; @@ -912,7 +914,6 @@ void CommandLineInterface::writeLinkedFiles() bool CommandLineInterface::assemble() { - //@TODO later, we will use the convenience interface and should also remove the include above bool successful = true; map> scanners; for (auto const& src: m_sourceCodes) @@ -926,6 +927,7 @@ bool CommandLineInterface::assemble() m_assemblyStacks[src.first].assemble(); } for (auto const& stack: m_assemblyStacks) + { for (auto const& error: stack.second.errors()) SourceReferenceFormatter::printExceptionInformation( cerr, @@ -933,6 +935,9 @@ bool CommandLineInterface::assemble() (error->type() == Error::Type::Warning) ? "Warning" : "Error", [&](string const& _source) -> Scanner const& { return *scanners.at(_source); } ); + if (!Error::containsOnlyWarnings(stack.second.errors())) + successful = false; + } return successful; } diff --git a/solc/CommandLineInterface.h b/solc/CommandLineInterface.h index b8fc1823b..bcfc43d73 100644 --- a/solc/CommandLineInterface.h +++ b/solc/CommandLineInterface.h @@ -21,12 +21,14 @@ */ #pragma once -#include -#include -#include #include #include +#include +#include + +#include + namespace dev { namespace solidity