cerc-io/solidity
10
0
Fork 0
mirror of https://github.com/ethereum/solidity synced 2023-10-03 13:03:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6027 from ethereum/failEnErrorListNonEmpty

Browse Source 
Make analysis success not only dependent on flag but also on error list.
This commit is contained in:
chriseth 2019-02-20 15:19:48 +01:00 committed by GitHub
commit 00084a9bd7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libyul/AsmAnalysis.cpp
View File

@ -52,7 +52,10 @@ bool AsmAnalyzer::analyze(Block const& _block)
if (!(ScopeFiller(m_info, m_errorReporter))(_block)) if (!(ScopeFiller(m_info, m_errorReporter))(_block))
return false; return false;
return (*this)(_block); bool success = (*this)(_block);
if (!success)
solAssert(m_errorReporter.hasErrors(), "No success but no error.");
return success && !m_errorReporter.hasErrors();
} }
AsmAnalysisInfo AsmAnalyzer::analyzeStrictAssertCorrect( AsmAnalysisInfo AsmAnalyzer::analyzeStrictAssertCorrect(