solidity/libsolidity/analysis/ViewPureChecker.cpp

422 lines
13 KiB
C++
Raw Normal View History

2017-08-28 17:48:34 +00:00
/*
This file is part of solidity.
solidity is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
solidity is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with solidity. If not, see <http://www.gnu.org/licenses/>.
*/
#include <libsolidity/analysis/ViewPureChecker.h>
#include <libsolidity/ast/ExperimentalFeatures.h>
#include <libyul/AsmData.h>
#include <libyul/backends/evm/EVMDialect.h>
#include <liblangutil/ErrorReporter.h>
2018-12-17 11:30:08 +00:00
#include <libevmasm/SemanticInformation.h>
2017-08-31 11:13:35 +00:00
#include <functional>
2017-08-28 17:48:34 +00:00
using namespace std;
using namespace dev;
using namespace langutil;
2017-08-28 17:48:34 +00:00
using namespace dev::solidity;
2017-09-01 17:58:38 +00:00
namespace
{
2017-08-31 11:13:35 +00:00
class AssemblyViewPureChecker: public boost::static_visitor<void>
{
public:
explicit AssemblyViewPureChecker(
yul::Dialect const& _dialect,
std::function<void(StateMutability, SourceLocation const&)> _reportMutability
):
m_dialect(_dialect),
2017-08-31 11:13:35 +00:00
m_reportMutability(_reportMutability) {}
void operator()(yul::Label const&) { }
void operator()(yul::Instruction const& _instruction)
2017-08-31 11:13:35 +00:00
{
checkInstruction(_instruction.location, _instruction.instruction);
2017-08-31 11:13:35 +00:00
}
void operator()(yul::Literal const&) {}
void operator()(yul::Identifier const&) {}
void operator()(yul::FunctionalInstruction const& _instr)
2017-08-31 11:13:35 +00:00
{
checkInstruction(_instr.location, _instr.instruction);
2017-08-31 11:13:35 +00:00
for (auto const& arg: _instr.arguments)
boost::apply_visitor(*this, arg);
}
void operator()(yul::ExpressionStatement const& _expr)
2017-12-08 13:01:22 +00:00
{
boost::apply_visitor(*this, _expr.expression);
}
void operator()(yul::StackAssignment const&) {}
void operator()(yul::Assignment const& _assignment)
2017-08-31 11:13:35 +00:00
{
boost::apply_visitor(*this, *_assignment.value);
}
void operator()(yul::VariableDeclaration const& _varDecl)
2017-08-31 11:13:35 +00:00
{
if (_varDecl.value)
boost::apply_visitor(*this, *_varDecl.value);
}
void operator()(yul::FunctionDefinition const& _funDef)
2017-08-31 11:13:35 +00:00
{
(*this)(_funDef.body);
}
void operator()(yul::FunctionCall const& _funCall)
2017-08-31 11:13:35 +00:00
{
if (yul::EVMDialect const* dialect = dynamic_cast<decltype(dialect)>(&m_dialect))
if (yul::BuiltinFunctionForEVM const* fun = dialect->builtin(_funCall.functionName.name))
if (fun->instruction)
checkInstruction(_funCall.location, *fun->instruction);
2017-08-31 11:13:35 +00:00
for (auto const& arg: _funCall.arguments)
boost::apply_visitor(*this, arg);
}
void operator()(yul::If const& _if)
{
boost::apply_visitor(*this, *_if.condition);
(*this)(_if.body);
}
void operator()(yul::Switch const& _switch)
2017-08-31 11:13:35 +00:00
{
boost::apply_visitor(*this, *_switch.expression);
for (auto const& _case: _switch.cases)
{
if (_case.value)
(*this)(*_case.value);
(*this)(_case.body);
}
}
void operator()(yul::ForLoop const& _for)
2017-08-31 11:13:35 +00:00
{
(*this)(_for.pre);
boost::apply_visitor(*this, *_for.condition);
(*this)(_for.body);
(*this)(_for.post);
}
void operator()(yul::Break const&)
{
}
void operator()(yul::Continue const&)
{
}
void operator()(yul::Block const& _block)
2017-08-31 11:13:35 +00:00
{
for (auto const& s: _block.statements)
boost::apply_visitor(*this, s);
}
private:
void checkInstruction(SourceLocation _location, dev::eth::Instruction _instruction)
{
if (eth::SemanticInformation::invalidInViewFunctions(_instruction))
m_reportMutability(StateMutability::NonPayable, _location);
else if (eth::SemanticInformation::invalidInPureFunctions(_instruction))
m_reportMutability(StateMutability::View, _location);
}
yul::Dialect const& m_dialect;
std::function<void(StateMutability, SourceLocation const&)> m_reportMutability;
2017-08-31 11:13:35 +00:00
};
2017-09-01 17:58:38 +00:00
}
2017-08-31 11:13:35 +00:00
2017-08-28 17:48:34 +00:00
bool ViewPureChecker::check()
{
vector<ContractDefinition const*> contracts;
2017-08-28 17:48:34 +00:00
for (auto const& node: m_ast)
{
SourceUnit const* source = dynamic_cast<SourceUnit const*>(node.get());
solAssert(source, "");
contracts += source->filteredNodes<ContractDefinition>(source->nodes());
2017-08-28 17:48:34 +00:00
}
// Check modifiers first to infer their state mutability.
for (auto const& contract: contracts)
for (ModifierDefinition const* mod: contract->functionModifiers())
2017-08-28 17:48:34 +00:00
mod->accept(*this);
for (auto const& contract: contracts)
contract->accept(*this);
2017-08-28 17:48:34 +00:00
return !m_errors;
}
bool ViewPureChecker::visit(FunctionDefinition const& _funDef)
{
solAssert(!m_currentFunction, "");
m_currentFunction = &_funDef;
m_bestMutabilityAndLocation = {StateMutability::Pure, _funDef.location()};
2017-08-28 17:48:34 +00:00
return true;
}
void ViewPureChecker::endVisit(FunctionDefinition const& _funDef)
{
solAssert(m_currentFunction == &_funDef, "");
if (
m_bestMutabilityAndLocation.mutability < _funDef.stateMutability() &&
2017-08-28 17:48:34 +00:00
_funDef.stateMutability() != StateMutability::Payable &&
_funDef.isImplemented() &&
!_funDef.body().statements().empty() &&
2017-08-28 17:48:34 +00:00
!_funDef.isConstructor() &&
!_funDef.isFallback() &&
!_funDef.annotation().superFunction
)
m_errorReporter.warning(
_funDef.location(),
"Function state mutability can be restricted to " + stateMutabilityToString(m_bestMutabilityAndLocation.mutability)
2017-08-28 17:48:34 +00:00
);
m_currentFunction = nullptr;
}
bool ViewPureChecker::visit(ModifierDefinition const& _modifier)
2017-08-28 17:48:34 +00:00
{
solAssert(m_currentFunction == nullptr, "");
m_bestMutabilityAndLocation = {StateMutability::Pure, _modifier.location()};
2017-08-28 17:48:34 +00:00
return true;
}
void ViewPureChecker::endVisit(ModifierDefinition const& _modifierDef)
{
solAssert(m_currentFunction == nullptr, "");
m_inferredMutability[&_modifierDef] = std::move(m_bestMutabilityAndLocation);
2017-08-28 17:48:34 +00:00
}
void ViewPureChecker::endVisit(Identifier const& _identifier)
{
Declaration const* declaration = _identifier.annotation().referencedDeclaration;
solAssert(declaration, "");
StateMutability mutability = StateMutability::Pure;
bool writes = _identifier.annotation().lValueRequested;
if (VariableDeclaration const* varDecl = dynamic_cast<VariableDeclaration const*>(declaration))
{
if (varDecl->isStateVariable() && !varDecl->isConstant())
2017-08-28 17:48:34 +00:00
mutability = writes ? StateMutability::NonPayable : StateMutability::View;
}
else if (MagicVariableDeclaration const* magicVar = dynamic_cast<MagicVariableDeclaration const*>(declaration))
{
switch (magicVar->type()->category())
{
case Type::Category::Contract:
solAssert(_identifier.name() == "this" || _identifier.name() == "super", "");
if (!dynamic_cast<ContractType const&>(*magicVar->type()).isSuper())
// reads the address
mutability = StateMutability::View;
break;
case Type::Category::Integer:
solAssert(_identifier.name() == "now", "");
mutability = StateMutability::View;
break;
default:
break;
}
}
2017-08-31 11:13:35 +00:00
reportMutability(mutability, _identifier.location());
2017-08-28 17:48:34 +00:00
}
void ViewPureChecker::endVisit(InlineAssembly const& _inlineAssembly)
{
2017-08-31 11:13:35 +00:00
AssemblyViewPureChecker{
_inlineAssembly.dialect(),
2017-09-13 15:29:27 +00:00
[=](StateMutability _mutability, SourceLocation const& _location) { reportMutability(_mutability, _location); }
2017-08-31 11:13:35 +00:00
}(_inlineAssembly.operations());
2017-08-28 17:48:34 +00:00
}
void ViewPureChecker::reportMutability(
StateMutability _mutability,
SourceLocation const& _location,
boost::optional<SourceLocation> const& _nestedLocation
)
2017-08-28 17:48:34 +00:00
{
if (_mutability > m_bestMutabilityAndLocation.mutability)
m_bestMutabilityAndLocation = MutabilityAndLocation{_mutability, _location};
if (!m_currentFunction || _mutability <= m_currentFunction->stateMutability())
return;
// Check for payable here, because any occurrence of `msg.value`
// will set mutability to payable.
if (_mutability == StateMutability::View || (
_mutability == StateMutability::Payable &&
m_currentFunction->stateMutability() == StateMutability::Pure
))
2017-08-28 17:48:34 +00:00
{
m_errorReporter.typeError(
_location,
"Function declared as pure, but this expression (potentially) reads from the "
"environment or state and thus requires \"view\"."
);
m_errors = true;
2017-08-28 17:48:34 +00:00
}
else if (_mutability == StateMutability::NonPayable)
{
m_errorReporter.typeError(
_location,
"Function declared as " +
stateMutabilityToString(m_currentFunction->stateMutability()) +
", but this expression (potentially) modifies the state and thus "
"requires non-payable (the default) or payable."
);
m_errors = true;
}
else if (_mutability == StateMutability::Payable)
{
// We do not warn for library functions because they cannot be payable anyway.
// Also internal functions should be allowed to use `msg.value`.
if (m_currentFunction->isPublic() && m_currentFunction->inContractKind() != ContractDefinition::ContractKind::Library)
{
if (_nestedLocation)
2018-08-16 15:28:49 +00:00
m_errorReporter.typeError(
_location,
SecondarySourceLocation().append("\"msg.value\" or \"callvalue()\" appear here inside the modifier.", *_nestedLocation),
"This modifier uses \"msg.value\" or \"callvalue()\" and thus the function has to be payable or internal."
);
else
2018-08-16 15:28:49 +00:00
m_errorReporter.typeError(
_location,
"\"msg.value\" and \"callvalue()\" can only be used in payable public functions. Make the function "
2018-08-16 15:28:49 +00:00
"\"payable\" or use an internal function to avoid this error."
);
2018-08-16 15:28:49 +00:00
m_errors = true;
}
}
else
solAssert(false, "");
solAssert(
m_currentFunction->stateMutability() == StateMutability::View ||
m_currentFunction->stateMutability() == StateMutability::Pure ||
m_currentFunction->stateMutability() == StateMutability::NonPayable,
""
);
2017-08-28 17:48:34 +00:00
}
void ViewPureChecker::endVisit(FunctionCall const& _functionCall)
{
if (_functionCall.annotation().kind != FunctionCallKind::FunctionCall)
return;
2018-10-04 11:03:55 +00:00
StateMutability mutability = dynamic_cast<FunctionType const&>(*_functionCall.expression().annotation().type).stateMutability();
2017-08-28 17:48:34 +00:00
// We only require "nonpayable" to call a payble function.
2018-10-04 11:03:55 +00:00
if (mutability == StateMutability::Payable)
mutability = StateMutability::NonPayable;
reportMutability(mutability, _functionCall.location());
2017-08-28 17:48:34 +00:00
}
2018-02-13 08:49:50 +00:00
bool ViewPureChecker::visit(MemberAccess const& _memberAccess)
{
// Catch the special case of `this.f.selector` which is a pure expression.
ASTString const& member = _memberAccess.memberName();
if (
_memberAccess.expression().annotation().type->category() == Type::Category::Function &&
member == "selector"
)
if (auto const* expr = dynamic_cast<MemberAccess const*>(&_memberAccess.expression()))
if (auto const* exprInt = dynamic_cast<Identifier const*>(&expr->expression()))
if (exprInt->name() == "this")
// Do not continue visiting.
return false;
return true;
}
2017-08-28 17:48:34 +00:00
void ViewPureChecker::endVisit(MemberAccess const& _memberAccess)
{
StateMutability mutability = StateMutability::Pure;
bool writes = _memberAccess.annotation().lValueRequested;
ASTString const& member = _memberAccess.memberName();
switch (_memberAccess.expression().annotation().type->category())
{
case Type::Category::Address:
if (member == "balance")
2017-08-28 17:48:34 +00:00
mutability = StateMutability::View;
break;
case Type::Category::Magic:
{
using MagicMember = pair<MagicType::Kind, string>;
set<MagicMember> static const pureMembers{
{MagicType::Kind::ABI, "decode"},
{MagicType::Kind::ABI, "encode"},
{MagicType::Kind::ABI, "encodePacked"},
{MagicType::Kind::ABI, "encodeWithSelector"},
{MagicType::Kind::ABI, "encodeWithSignature"},
{MagicType::Kind::Block, "blockhash"},
{MagicType::Kind::Message, "data"},
2019-01-10 15:28:39 +00:00
{MagicType::Kind::Message, "sig"},
{MagicType::Kind::MetaType, "creationCode"},
{MagicType::Kind::MetaType, "runtimeCode"},
{MagicType::Kind::MetaType, "name"},
};
set<MagicMember> static const payableMembers{
{MagicType::Kind::Message, "value"}
};
auto const& type = dynamic_cast<MagicType const&>(*_memberAccess.expression().annotation().type);
MagicMember magicMember(type.kind(), member);
if (!pureMembers.count(magicMember))
2017-08-28 17:48:34 +00:00
mutability = StateMutability::View;
if (payableMembers.count(magicMember))
mutability = StateMutability::Payable;
2017-08-28 17:48:34 +00:00
break;
}
2017-08-28 17:48:34 +00:00
case Type::Category::Struct:
{
if (_memberAccess.expression().annotation().type->dataStoredIn(DataLocation::Storage))
mutability = writes ? StateMutability::NonPayable : StateMutability::View;
break;
}
case Type::Category::Array:
{
auto const& type = dynamic_cast<ArrayType const&>(*_memberAccess.expression().annotation().type);
if (member == "length" && type.isDynamicallySized() && type.dataStoredIn(DataLocation::Storage))
mutability = writes ? StateMutability::NonPayable : StateMutability::View;
break;
}
default:
break;
}
2017-08-31 11:13:35 +00:00
reportMutability(mutability, _memberAccess.location());
2017-08-28 17:48:34 +00:00
}
void ViewPureChecker::endVisit(IndexAccess const& _indexAccess)
{
2017-09-01 10:31:24 +00:00
if (!_indexAccess.indexExpression())
solAssert(_indexAccess.annotation().type->category() == Type::Category::TypeType, "");
else
{
bool writes = _indexAccess.annotation().lValueRequested;
if (_indexAccess.baseExpression().annotation().type->dataStoredIn(DataLocation::Storage))
reportMutability(writes ? StateMutability::NonPayable : StateMutability::View, _indexAccess.location());
}
2017-08-28 17:48:34 +00:00
}
void ViewPureChecker::endVisit(ModifierInvocation const& _modifier)
{
solAssert(_modifier.name(), "");
if (ModifierDefinition const* mod = dynamic_cast<decltype(mod)>(_modifier.name()->annotation().referencedDeclaration))
{
solAssert(m_inferredMutability.count(mod), "");
auto const& mutAndLocation = m_inferredMutability.at(mod);
reportMutability(mutAndLocation.mutability, _modifier.location(), mutAndLocation.location);
}
else
solAssert(dynamic_cast<ContractDefinition const*>(_modifier.name()->annotation().referencedDeclaration), "");
2017-08-28 17:48:34 +00:00
}