2018-10-23 13:55:48 +00:00
|
|
|
/*
|
|
|
|
This file is part of solidity.
|
|
|
|
|
|
|
|
solidity is free software: you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
solidity is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with solidity. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
/**
|
|
|
|
* Optimiser component that removes assignments to variables that are not used
|
|
|
|
* until they go out of scope or are re-assigned.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <libyul/optimiser/RedundantAssignEliminator.h>
|
|
|
|
|
|
|
|
#include <libyul/optimiser/Semantics.h>
|
2018-11-23 10:18:57 +00:00
|
|
|
#include <libyul/AsmData.h>
|
2018-10-23 13:55:48 +00:00
|
|
|
|
|
|
|
#include <libdevcore/CommonData.h>
|
|
|
|
|
|
|
|
#include <boost/range/algorithm_ext/erase.hpp>
|
|
|
|
|
|
|
|
using namespace std;
|
|
|
|
using namespace dev;
|
2018-11-21 11:42:34 +00:00
|
|
|
using namespace yul;
|
2018-10-23 13:55:48 +00:00
|
|
|
using namespace dev::solidity;
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::operator()(Identifier const& _identifier)
|
|
|
|
{
|
|
|
|
changeUndecidedTo(_identifier.name, State::Used);
|
|
|
|
}
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::operator()(VariableDeclaration const& _variableDeclaration)
|
|
|
|
{
|
|
|
|
ASTWalker::operator()(_variableDeclaration);
|
|
|
|
|
|
|
|
for (auto const& var: _variableDeclaration.variables)
|
2018-10-29 14:12:02 +00:00
|
|
|
m_declaredVariables.emplace(var.name);
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::operator()(Assignment const& _assignment)
|
|
|
|
{
|
|
|
|
visit(*_assignment.value);
|
|
|
|
for (auto const& var: _assignment.variableNames)
|
|
|
|
changeUndecidedTo(var.name, State::Unused);
|
|
|
|
|
|
|
|
if (_assignment.variableNames.size() == 1)
|
|
|
|
// Default-construct it in "Undecided" state if it does not yet exist.
|
|
|
|
m_assignments[_assignment.variableNames.front().name][&_assignment];
|
|
|
|
}
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::operator()(If const& _if)
|
|
|
|
{
|
|
|
|
visit(*_if.condition);
|
|
|
|
|
2019-03-18 16:38:25 +00:00
|
|
|
TrackedAssignments skipBranch{m_assignments};
|
|
|
|
(*this)(_if.body);
|
2018-10-23 13:55:48 +00:00
|
|
|
|
2019-03-18 16:38:25 +00:00
|
|
|
merge(m_assignments, move(skipBranch));
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::operator()(Switch const& _switch)
|
|
|
|
{
|
|
|
|
visit(*_switch.expression);
|
|
|
|
|
2019-03-18 16:38:25 +00:00
|
|
|
TrackedAssignments const preState{m_assignments};
|
|
|
|
|
2018-10-23 13:55:48 +00:00
|
|
|
bool hasDefault = false;
|
2019-03-18 16:38:25 +00:00
|
|
|
vector<TrackedAssignments> branches;
|
2018-10-23 13:55:48 +00:00
|
|
|
for (auto const& c: _switch.cases)
|
|
|
|
{
|
|
|
|
if (!c.value)
|
|
|
|
hasDefault = true;
|
2019-03-18 16:38:25 +00:00
|
|
|
(*this)(c.body);
|
|
|
|
branches.emplace_back(move(m_assignments));
|
|
|
|
m_assignments = preState;
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (hasDefault)
|
|
|
|
{
|
2019-03-18 16:38:25 +00:00
|
|
|
m_assignments = move(branches.back());
|
2018-10-23 13:55:48 +00:00
|
|
|
branches.pop_back();
|
|
|
|
}
|
|
|
|
for (auto& branch: branches)
|
2019-03-18 16:38:25 +00:00
|
|
|
merge(m_assignments, move(branch));
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::operator()(FunctionDefinition const& _functionDefinition)
|
|
|
|
{
|
2019-03-18 16:38:25 +00:00
|
|
|
std::set<YulString> outerDeclaredVariables;
|
|
|
|
TrackedAssignments outerAssignments;
|
2019-03-26 16:35:26 +00:00
|
|
|
ForLoopInfo forLoopInfo;
|
2019-03-18 16:38:25 +00:00
|
|
|
swap(m_declaredVariables, outerDeclaredVariables);
|
|
|
|
swap(m_assignments, outerAssignments);
|
2019-03-26 16:35:26 +00:00
|
|
|
swap(m_forLoopInfo, forLoopInfo);
|
2019-02-21 19:04:20 +00:00
|
|
|
|
2018-10-23 13:55:48 +00:00
|
|
|
(*this)(_functionDefinition.body);
|
|
|
|
|
|
|
|
for (auto const& param: _functionDefinition.parameters)
|
2019-03-26 16:35:26 +00:00
|
|
|
finalize(param.name, State::Unused);
|
2018-10-23 13:55:48 +00:00
|
|
|
for (auto const& retParam: _functionDefinition.returnVariables)
|
2019-03-26 16:35:26 +00:00
|
|
|
finalize(retParam.name, State::Used);
|
2019-02-21 19:04:20 +00:00
|
|
|
|
2019-03-18 16:38:25 +00:00
|
|
|
swap(m_declaredVariables, outerDeclaredVariables);
|
|
|
|
swap(m_assignments, outerAssignments);
|
2019-03-26 16:35:26 +00:00
|
|
|
swap(m_forLoopInfo, forLoopInfo);
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::operator()(ForLoop const& _forLoop)
|
|
|
|
{
|
2019-03-26 16:35:26 +00:00
|
|
|
ForLoopInfo outerForLoopInfo;
|
|
|
|
swap(outerForLoopInfo, m_forLoopInfo);
|
|
|
|
|
|
|
|
set<YulString> outerDeclaredVariables;
|
|
|
|
swap(m_declaredVariables, outerDeclaredVariables);
|
2018-10-23 13:55:48 +00:00
|
|
|
|
|
|
|
// We need to visit the statements directly because of the
|
|
|
|
// scoping rules.
|
|
|
|
walkVector(_forLoop.pre.statements);
|
|
|
|
|
|
|
|
// We just run the loop twice to account for the
|
|
|
|
// back edge.
|
|
|
|
// There need not be more runs because we only have three different states.
|
|
|
|
|
|
|
|
visit(*_forLoop.condition);
|
|
|
|
|
2019-03-18 16:38:25 +00:00
|
|
|
TrackedAssignments zeroRuns{m_assignments};
|
2018-10-23 13:55:48 +00:00
|
|
|
|
|
|
|
(*this)(_forLoop.body);
|
2019-03-18 16:43:28 +00:00
|
|
|
merge(m_assignments, move(m_forLoopInfo.pendingContinueStmts));
|
|
|
|
m_forLoopInfo.pendingContinueStmts = {};
|
2018-10-23 13:55:48 +00:00
|
|
|
(*this)(_forLoop.post);
|
|
|
|
|
|
|
|
visit(*_forLoop.condition);
|
|
|
|
|
2019-03-18 16:38:25 +00:00
|
|
|
TrackedAssignments oneRun{m_assignments};
|
2018-10-23 13:55:48 +00:00
|
|
|
|
|
|
|
(*this)(_forLoop.body);
|
2019-03-18 16:43:28 +00:00
|
|
|
|
|
|
|
merge(m_assignments, move(m_forLoopInfo.pendingContinueStmts));
|
2019-03-26 16:35:26 +00:00
|
|
|
m_forLoopInfo.pendingContinueStmts.clear();
|
2018-10-23 13:55:48 +00:00
|
|
|
(*this)(_forLoop.post);
|
|
|
|
|
|
|
|
visit(*_forLoop.condition);
|
|
|
|
|
|
|
|
// Order does not matter because "max" is commutative and associative.
|
2019-03-18 16:38:25 +00:00
|
|
|
merge(m_assignments, move(oneRun));
|
|
|
|
merge(m_assignments, move(zeroRuns));
|
2019-03-18 16:43:28 +00:00
|
|
|
merge(m_assignments, move(m_forLoopInfo.pendingBreakStmts));
|
2019-03-26 16:35:26 +00:00
|
|
|
m_forLoopInfo.pendingBreakStmts.clear();
|
2019-03-18 16:43:28 +00:00
|
|
|
|
2019-03-26 16:35:26 +00:00
|
|
|
for (auto const& var: m_declaredVariables)
|
|
|
|
finalize(var, State::Unused);
|
|
|
|
swap(m_declaredVariables, outerDeclaredVariables);
|
|
|
|
|
|
|
|
// Restore potential outer for-loop states.
|
2019-03-18 16:43:28 +00:00
|
|
|
swap(m_forLoopInfo, outerForLoopInfo);
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
|
|
|
|
2019-03-04 14:38:05 +00:00
|
|
|
void RedundantAssignEliminator::operator()(Break const&)
|
|
|
|
{
|
2019-03-26 16:35:26 +00:00
|
|
|
m_forLoopInfo.pendingBreakStmts.emplace_back(move(m_assignments));
|
|
|
|
m_assignments.clear();
|
2019-03-04 14:38:05 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::operator()(Continue const&)
|
|
|
|
{
|
2019-03-26 16:35:26 +00:00
|
|
|
m_forLoopInfo.pendingContinueStmts.emplace_back(move(m_assignments));
|
|
|
|
m_assignments.clear();
|
2019-03-04 14:38:05 +00:00
|
|
|
}
|
|
|
|
|
2018-10-23 13:55:48 +00:00
|
|
|
void RedundantAssignEliminator::operator()(Block const& _block)
|
|
|
|
{
|
2019-03-26 16:35:26 +00:00
|
|
|
set<YulString> outerDeclaredVariables;
|
|
|
|
swap(m_declaredVariables, outerDeclaredVariables);
|
2018-10-23 13:55:48 +00:00
|
|
|
|
|
|
|
ASTWalker::operator()(_block);
|
2019-03-26 16:35:26 +00:00
|
|
|
|
|
|
|
for (auto const& var: m_declaredVariables)
|
|
|
|
finalize(var, State::Unused);
|
|
|
|
|
|
|
|
swap(m_declaredVariables, outerDeclaredVariables);
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
|
|
|
|
2018-12-20 17:55:32 +00:00
|
|
|
void RedundantAssignEliminator::run(Dialect const& _dialect, Block& _ast)
|
2018-10-23 13:55:48 +00:00
|
|
|
{
|
2018-12-20 17:55:32 +00:00
|
|
|
RedundantAssignEliminator rae{_dialect};
|
2018-10-23 13:55:48 +00:00
|
|
|
rae(_ast);
|
|
|
|
|
2019-03-18 16:38:25 +00:00
|
|
|
AssignmentRemover remover{rae.m_pendingRemovals};
|
2018-10-23 13:55:48 +00:00
|
|
|
remover(_ast);
|
|
|
|
}
|
|
|
|
|
2018-10-29 14:12:31 +00:00
|
|
|
template <class K, class V, class F>
|
|
|
|
void joinMap(std::map<K, V>& _a, std::map<K, V>&& _b, F _conflictSolver)
|
2018-10-23 13:55:48 +00:00
|
|
|
{
|
2018-10-29 14:12:31 +00:00
|
|
|
// TODO Perhaps it is better to just create a sorted list
|
|
|
|
// and then use insert(begin, end)
|
|
|
|
|
|
|
|
auto ita = _a.begin();
|
|
|
|
auto aend = _a.end();
|
|
|
|
auto itb = _b.begin();
|
|
|
|
auto bend = _b.end();
|
|
|
|
|
|
|
|
for (; itb != bend; ++ita)
|
|
|
|
{
|
|
|
|
if (ita == aend)
|
|
|
|
ita = _a.insert(ita, std::move(*itb++));
|
|
|
|
else if (ita->first < itb->first)
|
|
|
|
continue;
|
|
|
|
else if (itb->first < ita->first)
|
|
|
|
ita = _a.insert(ita, std::move(*itb++));
|
|
|
|
else
|
2018-10-23 13:55:48 +00:00
|
|
|
{
|
2018-10-29 14:12:31 +00:00
|
|
|
_conflictSolver(ita->second, std::move(itb->second));
|
|
|
|
++itb;
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
2018-10-29 14:12:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-03-18 16:38:25 +00:00
|
|
|
void RedundantAssignEliminator::merge(TrackedAssignments& _target, TrackedAssignments&& _other)
|
2018-10-29 14:12:31 +00:00
|
|
|
{
|
2019-03-18 16:38:25 +00:00
|
|
|
joinMap(_target, move(_other), [](
|
2018-10-29 14:12:31 +00:00
|
|
|
map<Assignment const*, State>& _assignmentHere,
|
|
|
|
map<Assignment const*, State>&& _assignmentThere
|
|
|
|
)
|
|
|
|
{
|
2019-03-18 16:38:25 +00:00
|
|
|
return joinMap(_assignmentHere, move(_assignmentThere), State::join);
|
2018-10-29 14:12:31 +00:00
|
|
|
});
|
2018-10-23 13:55:48 +00:00
|
|
|
}
|
|
|
|
|
2019-03-18 16:43:28 +00:00
|
|
|
void RedundantAssignEliminator::merge(TrackedAssignments& _target, vector<TrackedAssignments>&& _source)
|
|
|
|
{
|
|
|
|
for (TrackedAssignments& ts: _source)
|
|
|
|
merge(_target, move(ts));
|
|
|
|
_source.clear();
|
|
|
|
}
|
|
|
|
|
2018-10-29 14:12:02 +00:00
|
|
|
void RedundantAssignEliminator::changeUndecidedTo(YulString _variable, RedundantAssignEliminator::State _newState)
|
2018-10-23 13:55:48 +00:00
|
|
|
{
|
|
|
|
for (auto& assignment: m_assignments[_variable])
|
2019-03-26 16:35:26 +00:00
|
|
|
if (assignment.second == State::Undecided)
|
2018-10-23 13:55:48 +00:00
|
|
|
assignment.second = _newState;
|
|
|
|
}
|
|
|
|
|
2019-03-26 16:35:26 +00:00
|
|
|
void RedundantAssignEliminator::finalize(YulString _variable, RedundantAssignEliminator::State _finalState)
|
2018-11-03 15:04:42 +00:00
|
|
|
{
|
2019-03-26 16:35:26 +00:00
|
|
|
finalize(m_assignments, _variable, _finalState);
|
|
|
|
for (auto& assignments: m_forLoopInfo.pendingBreakStmts)
|
|
|
|
finalize(assignments, _variable, _finalState);
|
|
|
|
for (auto& assignments: m_forLoopInfo.pendingContinueStmts)
|
|
|
|
finalize(assignments, _variable, _finalState);
|
|
|
|
}
|
|
|
|
|
|
|
|
void RedundantAssignEliminator::finalize(
|
|
|
|
TrackedAssignments& _assignments,
|
|
|
|
YulString _variable,
|
|
|
|
RedundantAssignEliminator::State _finalState
|
|
|
|
)
|
|
|
|
{
|
|
|
|
for (auto const& assignment: _assignments[_variable])
|
2018-11-03 15:04:42 +00:00
|
|
|
{
|
2019-03-26 16:35:26 +00:00
|
|
|
State const state = assignment.second == State::Undecided ? _finalState : assignment.second;
|
|
|
|
|
|
|
|
if (state == State::Unused && MovableChecker{*m_dialect, *assignment.first->value}.movable())
|
2018-11-03 15:04:42 +00:00
|
|
|
// TODO the only point where we actually need this
|
|
|
|
// to be a set is for the for loop
|
2019-03-18 16:38:25 +00:00
|
|
|
m_pendingRemovals.insert(assignment.first);
|
2018-11-03 15:04:42 +00:00
|
|
|
}
|
2019-03-26 16:35:26 +00:00
|
|
|
_assignments.erase(_variable);
|
2018-11-03 15:04:42 +00:00
|
|
|
}
|
|
|
|
|
2018-10-23 13:55:48 +00:00
|
|
|
void AssignmentRemover::operator()(Block& _block)
|
|
|
|
{
|
|
|
|
boost::range::remove_erase_if(_block.statements, [=](Statement const& _statement) -> bool {
|
|
|
|
return _statement.type() == typeid(Assignment) && m_toRemove.count(&boost::get<Assignment>(_statement));
|
|
|
|
});
|
|
|
|
|
|
|
|
ASTModifier::operator()(_block);
|
|
|
|
}
|