cerc-io/sodium-javascript
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix test with wrong buffer size

Browse Source 
Problem: For some reason the test sets `c` to 147 + 16 bytes, when we
only need 147 bytes. It's unclear to me why this is happening, but I can
confirm that Sodium-Native throws an error if you try this.

Solution: Use 147 bytes until I figure out what the problem is.
This commit is contained in:
Christian Bundy 2020-09-01 14:22:55 -07:00
parent f710e35ed2
commit a40b363726
1 changed files with 35 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
test_box_easy.js
View File

@ -69,52 +69,50 @@ const m = new Uint8Array([
]) ])
// static unsigned char c[147 + crypto_box_MACBYTES]; // static unsigned char c[147 + crypto_box_MACBYTES];
const c = new Uint8Array(147 + crypto_box_MACBYTES) // CHANGED: Neither Sodium-Native or Sodium-JavaScript handle when `c` is too big.
// I don't know why the test makes it so big, but if Sodium-Native throws
// then it seems like Sodium-JavaScript should throw too.
const c = new Uint8Array(147)
// // size_t i;
// int
// main(void)
// {
// size_t i;
// int ret;
let i let i
let ret
//
// ret = crypto_box_easy(c, m, 131, nonce, bobpk, alicesk);
// assert(ret == 0);
ret = crypto_box_easy(c, m, nonce, bobpk, alicesk)
// for (i = 0; i < 131 + crypto_box_MACBYTES; ++i) { // int ret;
// printf(",0x%02x", (unsigned int) c[i]); // ret = crypto_box_easy(c, m, 131, nonce, bobpk, alicesk);
// } // assert(ret == 0);
let ret = crypto_box_easy(c, m, nonce, bobpk, alicesk)
// for (i = 0; i < 131 + crypto_box_MACBYTES; ++i) {
// printf(",0x%02x", (unsigned int) c[i]);
// }
for (i = 0; i < 131 + crypto_box_MACBYTES; ++i) { for (i = 0; i < 131 + crypto_box_MACBYTES; ++i) {
const hex = c[i].toString(16).padStart(2, '0') const hex = c[i].toString(16).padStart(2, '0')
process.stdout.write(`,0x${hex}`) process.stdout.write(`,0x${hex}`)
} }
// printf("\n");
// printf("\n");
process.stdout.write('\n') process.stdout.write('\n')
// /* Null message */
// //
// /* Null message */ // ret = crypto_box_easy(c, guard_page, 0, nonce, bobpk, alicesk);
// // assert(ret == 0);
// ret = crypto_box_easy(c, guard_page, 0, nonce, bobpk, alicesk); // for (i = 0; i < 1 + crypto_box_MACBYTES; ++i) {
// assert(ret == 0); // printf(",0x%02x", (unsigned int) c[i]);
// for (i = 0; i < 1 + crypto_box_MACBYTES; ++i) {
// printf(",0x%02x", (unsigned int) c[i]);
// }
// printf("\n");
//
// ret =
// crypto_box_open_easy(c, c, crypto_box_MACBYTES, nonce, bobpk, alicesk);
// assert(ret == 0);
// for (i = 0; i < 1 + crypto_box_MACBYTES; ++i) {
// printf(",0x%02x", (unsigned int) c[i]);
// }
// printf("\n");
// c[randombytes_uniform(crypto_box_MACBYTES)]++;
// ret = crypto_box_open_easy(c, c, crypto_box_MACBYTES, nonce, bobpk, alicesk);
// assert(ret == -1);
//
// return 0;
// } // }
// printf("\n");
//
// ret =
// crypto_box_open_easy(c, c, crypto_box_MACBYTES, nonce, bobpk, alicesk);
// assert(ret == 0);
// for (i = 0; i < 1 + crypto_box_MACBYTES; ++i) {
// printf(",0x%02x", (unsigned int) c[i]);
// }
// printf("\n");
// c[randombytes_uniform(crypto_box_MACBYTES)]++;
// ret = crypto_box_open_easy(c, c, crypto_box_MACBYTES, nonce, bobpk, alicesk);
// assert(ret == -1);
//
// return 0;
if (typeof window !== 'undefined') window.close() if (typeof window !== 'undefined') window.close()