cerc-io/snowballtools-base
16
0
Fork 2
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

bug in Wallet Connect #24

New Issue
Closed
opened 2024-10-31 14:45:54 +00:00 by zramsay · 1 comment
zramsay commented 2024-10-31 14:45:54 +00:00
Member
Copy Link
  • the wallet doesn't always fully connect
  • the wallet doesn't stay connected to the app...something to go with persisting the pairing session
  • it neither persists nor expires properly
- the wallet doesn't always fully connect - the wallet doesn't stay connected to the app...something to go with persisting the pairing session - it neither persists nor expires properly
ashwin was assigned by zramsay 2024-10-31 14:45:54 +00:00
nabarun commented 2024-11-04 11:00:26 +00:00
Member
Copy Link

We could reproduce issues with Wallet Connect by doing the following:

  • In create new project flow, refresh the page after connecting wallet for pay & deploy
  • After refresh, pay & deploy stops working

Error seen in browser console after refresh

index-apijslfp.js:871 Object Error: No matching key. history: 1730281162223357
    at vE.getRecord (index.es-CLwiIwOL.js:8:53772)

We were able to resolve the issue by upgrading WalletConnect version from 2.12.2 to 2.16.1
There is no issue on app refresh now

The staging branch has been rebased onto main and now includes the above fix
App has been redeployed https://deploy.apps.vaasl.io

NOTE: Clear out deploy app cache and storage before checking the fix with Wallet Connect

We could reproduce issues with Wallet Connect by doing the following: - In create new project flow, refresh the page after connecting wallet for pay & deploy - After refresh, pay & deploy stops working Error seen in browser console after refresh ``` index-apijslfp.js:871 Object Error: No matching key. history: 1730281162223357 at vE.getRecord (index.es-CLwiIwOL.js:8:53772) ``` We were able to resolve the issue by upgrading WalletConnect version from `2.12.2` to `2.16.1` There is no issue on app refresh now The `staging` branch has been rebased onto `main` and now includes the above fix App has been redeployed https://deploy.apps.vaasl.io NOTE: Clear out deploy app cache and storage before checking the fix with Wallet Connect
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
ashwin
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/snowballtools-base#24
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?