From ef72a0351e8a29970a2e4fb4344ff98ada549e65 Mon Sep 17 00:00:00 2001
From: Nabarun Gogoi <nabarun@deepstacksoft.com>
Date: Fri, 22 Dec 2023 14:19:59 +0530
Subject: [PATCH] Refactor routes with layout and show search bar in project
 details page (#23)

* Refactor routes with layout and show search bar in project details page

* Set common search layout for child routes
---
 packages/frontend/src/App.tsx                 | 35 +++++++++++++++--
 .../src/components/projects/ProjectCard.tsx   |  2 +-
 ...ProjectSearch.tsx => ProjectSearchBar.tsx} |  4 +-
 .../create/template/deploy/DeployStep.tsx     |  2 +-
 .../project/settings/DeleteProjectDialog.tsx  |  4 +-
 packages/frontend/src/layouts/Dashboard.tsx   | 21 ++++++++++
 .../frontend/src/layouts/ProjectSearch.tsx    | 31 +++++++++++++++
 packages/frontend/src/pages/Settings.tsx      |  2 +-
 packages/frontend/src/pages/index.tsx         | 39 ++++++++++++++-----
 .../frontend/src/pages/projects/Create.tsx    | 14 ++++---
 .../frontend/src/pages/projects/Project.tsx   |  2 +-
 .../{Projects.tsx => projects/index.tsx}      | 25 ++----------
 .../frontend/src/pages/projects/routes.tsx    | 13 ++++---
 packages/frontend/src/pages/routes.tsx        | 20 ----------
 14 files changed, 141 insertions(+), 73 deletions(-)
 rename packages/frontend/src/components/projects/{ProjectSearch.tsx => ProjectSearchBar.tsx} (96%)
 create mode 100644 packages/frontend/src/layouts/Dashboard.tsx
 create mode 100644 packages/frontend/src/layouts/ProjectSearch.tsx
 rename packages/frontend/src/pages/{Projects.tsx => projects/index.tsx} (50%)
 delete mode 100644 packages/frontend/src/pages/routes.tsx

diff --git a/packages/frontend/src/App.tsx b/packages/frontend/src/App.tsx
index 0efb68b0..78908393 100644
--- a/packages/frontend/src/App.tsx
+++ b/packages/frontend/src/App.tsx
@@ -1,14 +1,41 @@
 import React from 'react';
 import { createBrowserRouter, RouterProvider } from 'react-router-dom';
 
+import DashboardLayout from './layouts/Dashboard';
 import Home from './pages/index';
-import { homeRoutes } from './pages/routes';
+import Settings from './pages/Settings';
+import {
+  projectsRoutesWithSearch,
+  projectsRoutesWithoutSearch,
+} from './pages/projects/routes';
+import ProjectSearchLayout from './layouts/ProjectSearch';
 
 const router = createBrowserRouter([
   {
-    path: '/',
-    element: <Home />,
-    children: homeRoutes,
+    element: <DashboardLayout />,
+    children: [
+      {
+        element: <ProjectSearchLayout />,
+        children: [
+          {
+            path: '/',
+            element: <Home />,
+          },
+          {
+            path: 'projects',
+            children: projectsRoutesWithSearch,
+          },
+        ],
+      },
+      {
+        path: 'settings',
+        element: <Settings />,
+      },
+      {
+        path: 'projects',
+        children: projectsRoutesWithoutSearch,
+      },
+    ],
   },
 ]);
 
diff --git a/packages/frontend/src/components/projects/ProjectCard.tsx b/packages/frontend/src/components/projects/ProjectCard.tsx
index afa24369..338fa764 100644
--- a/packages/frontend/src/components/projects/ProjectCard.tsx
+++ b/packages/frontend/src/components/projects/ProjectCard.tsx
@@ -39,7 +39,7 @@ const ProjectCard: React.FC<ProjectCardProps> = ({ project }) => {
           </MenuList>
         </Menu>
       </div>
-      <div className="border-slate-200 border-t-2 border-solid p-4 bg-gray-50">
+      <div className="border-t-2 border-solid p-4 bg-gray-50">
         <Typography variant="small" color="gray">
           {project.latestCommit.message}
         </Typography>
diff --git a/packages/frontend/src/components/projects/ProjectSearch.tsx b/packages/frontend/src/components/projects/ProjectSearchBar.tsx
similarity index 96%
rename from packages/frontend/src/components/projects/ProjectSearch.tsx
rename to packages/frontend/src/components/projects/ProjectSearchBar.tsx
index e5037431..b958eaa3 100644
--- a/packages/frontend/src/components/projects/ProjectSearch.tsx
+++ b/packages/frontend/src/components/projects/ProjectSearchBar.tsx
@@ -17,7 +17,7 @@ interface ProjectsSearchProps {
   onChange?: (data: ProjectDetails) => void;
 }
 
-const ProjectSearch = ({ onChange }: ProjectsSearchProps) => {
+const ProjectSearchBar = ({ onChange }: ProjectsSearchProps) => {
   const [items, setItems] = useState<ProjectDetails[]>([]);
   const [selectedItem, setSelectedItem] = useState<ProjectDetails | null>(null);
 
@@ -105,4 +105,4 @@ const ProjectSearch = ({ onChange }: ProjectsSearchProps) => {
   );
 };
 
-export default ProjectSearch;
+export default ProjectSearchBar;
diff --git a/packages/frontend/src/components/projects/create/template/deploy/DeployStep.tsx b/packages/frontend/src/components/projects/create/template/deploy/DeployStep.tsx
index b2e18961..e064757e 100644
--- a/packages/frontend/src/components/projects/create/template/deploy/DeployStep.tsx
+++ b/packages/frontend/src/components/projects/create/template/deploy/DeployStep.tsx
@@ -31,7 +31,7 @@ const DeployStep = ({
   const [collapse, setCollapse] = useState(false);
 
   return (
-    <div className="border-b-2 border-slate-200">
+    <div className="border-b-2">
       <div className="flex justify-between p-2 gap-2">
         {status === DeployStatus.NOT_STARTED && <div>{step}</div>}
         {status === DeployStatus.PROCESSING && <div>O</div>}
diff --git a/packages/frontend/src/components/projects/project/settings/DeleteProjectDialog.tsx b/packages/frontend/src/components/projects/project/settings/DeleteProjectDialog.tsx
index 3463c2e0..4fdf6e34 100644
--- a/packages/frontend/src/components/projects/project/settings/DeleteProjectDialog.tsx
+++ b/packages/frontend/src/components/projects/project/settings/DeleteProjectDialog.tsx
@@ -57,8 +57,8 @@ const DeleteProjectDialog = ({
       >
         <DialogBody className="flex flex-col gap-2">
           <Typography variant="paragraph">
-            Deleting your project is irreversible. Enter your project’s name
-            &nbsp;
+            Deleting your project is irreversible. Enter your project’s
+            name&nbsp;
             <span className="bg-blue-100 text-blue-700">({project.name})</span>
             &nbsp;below to confirm you want to permanently delete it:
           </Typography>
diff --git a/packages/frontend/src/layouts/Dashboard.tsx b/packages/frontend/src/layouts/Dashboard.tsx
new file mode 100644
index 00000000..056f5dcb
--- /dev/null
+++ b/packages/frontend/src/layouts/Dashboard.tsx
@@ -0,0 +1,21 @@
+import React from 'react';
+import { Outlet } from 'react-router-dom';
+
+import Sidebar from '../components/Sidebar';
+
+const Dashboard = () => {
+  return (
+    <div className="grid grid-cols-5 h-screen bg-light-blue-50">
+      <div className="h-full">
+        <Sidebar />
+      </div>
+      <div className="col-span-4 h-full p-3">
+        <div className="bg-white rounded-3xl h-full">
+          <Outlet />
+        </div>
+      </div>
+    </div>
+  );
+};
+
+export default Dashboard;
diff --git a/packages/frontend/src/layouts/ProjectSearch.tsx b/packages/frontend/src/layouts/ProjectSearch.tsx
new file mode 100644
index 00000000..90772a8a
--- /dev/null
+++ b/packages/frontend/src/layouts/ProjectSearch.tsx
@@ -0,0 +1,31 @@
+import React from 'react';
+import { Outlet } from 'react-router-dom';
+
+import HorizontalLine from '../components/HorizontalLine';
+import { IconButton, Typography } from '@material-tailwind/react';
+import ProjectSearchBar from '../components/projects/ProjectSearchBar';
+
+const ProjectSearch = () => {
+  return (
+    <div>
+      <div className="flex p-5">
+        <div className="grow mr-2">
+          <ProjectSearchBar onChange={() => {}} />
+        </div>
+        <IconButton color="blue" className="rounded-full mr-2">
+          <Typography variant="h5">+</Typography>
+        </IconButton>
+        <div className="mr-2 flex items-center">
+          <Typography>^</Typography>
+        </div>
+        <div className="px-2 py-1 bg-blue-gray-50 rounded-lg">
+          <Typography variant="lead">SY</Typography>
+        </div>
+      </div>
+      <HorizontalLine />
+      <Outlet />
+    </div>
+  );
+};
+
+export default ProjectSearch;
diff --git a/packages/frontend/src/pages/Settings.tsx b/packages/frontend/src/pages/Settings.tsx
index cf834b75..dccab0ce 100644
--- a/packages/frontend/src/pages/Settings.tsx
+++ b/packages/frontend/src/pages/Settings.tsx
@@ -1,7 +1,7 @@
 import React from 'react';
 
 const Settings = () => {
-  return <div className="bg-white rounded-3xl h-full">Settings page</div>;
+  return <div className="p-5">Settings page</div>;
 };
 
 export default Settings;
diff --git a/packages/frontend/src/pages/index.tsx b/packages/frontend/src/pages/index.tsx
index 82d10bda..204b7a84 100644
--- a/packages/frontend/src/pages/index.tsx
+++ b/packages/frontend/src/pages/index.tsx
@@ -1,19 +1,40 @@
 import React from 'react';
-import { Outlet } from 'react-router-dom';
+import { Link } from 'react-router-dom';
 
-import Sidebar from '../components/Sidebar';
+import { Button, Typography, Chip } from '@material-tailwind/react';
 
-const Home = () => {
+import ProjectCard from '../components/projects/ProjectCard';
+import projectsDetail from '../assets/projects.json';
+
+const Projects = () => {
   return (
-    <div className="grid grid-cols-5 h-screen bg-light-blue-50">
-      <div className="h-full">
-        <Sidebar />
+    <div>
+      <div className="flex p-5">
+        <div className="grow">
+          <div className="flex gap-2 items-center">
+            <Typography variant="h4">Projects</Typography>
+            <Chip
+              className="bg-gray-300 rounded-full static"
+              value={projectsDetail.length}
+              size="sm"
+            />
+          </div>
+        </div>
+        <div>
+          <Link to="/projects/create">
+            <Button className="rounded-full" color="blue">
+              Create project
+            </Button>
+          </Link>
+        </div>
       </div>
-      <div className="col-span-4 h-full p-3">
-        <Outlet />
+      <div className="grid grid-cols-3 gap-5 p-5">
+        {projectsDetail.map((project, key) => {
+          return <ProjectCard project={project} key={key} />;
+        })}
       </div>
     </div>
   );
 };
 
-export default Home;
+export default Projects;
diff --git a/packages/frontend/src/pages/projects/Create.tsx b/packages/frontend/src/pages/projects/Create.tsx
index 52de4851..1f383105 100644
--- a/packages/frontend/src/pages/projects/Create.tsx
+++ b/packages/frontend/src/pages/projects/Create.tsx
@@ -1,20 +1,22 @@
 import React from 'react';
 import { Outlet, Link } from 'react-router-dom';
 
+import { IconButton } from '@material-tailwind/react';
+
 import HorizontalLine from '../../components/HorizontalLine';
 
 const CreateProject = () => {
   return (
-    <div className="bg-white rounded-3xl h-full p-4">
-      <div className="flex p-2">
-        <div className="grow p-4">
+    <div className="h-full">
+      <div className="flex p-4 items-center">
+        <div className="grow">
           <h3 className="text-gray-750 text-2xl">Create new project</h3>
         </div>
-        <div className="p-4">
+        <div>
           <Link to="/">
-            <button className="bg-slate-300 text-gray-700 text-sm px-4 py-2 border rounded-full">
+            <IconButton className="rounded-full" variant="outlined">
               X
-            </button>
+            </IconButton>
           </Link>
         </div>
       </div>
diff --git a/packages/frontend/src/pages/projects/Project.tsx b/packages/frontend/src/pages/projects/Project.tsx
index 2ec96d15..8536622f 100644
--- a/packages/frontend/src/pages/projects/Project.tsx
+++ b/packages/frontend/src/pages/projects/Project.tsx
@@ -19,7 +19,7 @@ const Project = () => {
   const project = useMemo(() => getProject(Number(id)), [id]);
 
   return (
-    <div className="bg-white rounded-3xl h-full">
+    <div className="h-full">
       {project ? (
         <>
           <div className="flex p-4 gap-4 items-center">
diff --git a/packages/frontend/src/pages/Projects.tsx b/packages/frontend/src/pages/projects/index.tsx
similarity index 50%
rename from packages/frontend/src/pages/Projects.tsx
rename to packages/frontend/src/pages/projects/index.tsx
index daafcd5e..3f181baf 100644
--- a/packages/frontend/src/pages/Projects.tsx
+++ b/packages/frontend/src/pages/projects/index.tsx
@@ -1,31 +1,14 @@
 import React from 'react';
 import { Link } from 'react-router-dom';
 
-import { Button, IconButton, Typography, Chip } from '@material-tailwind/react';
+import { Button, Typography, Chip } from '@material-tailwind/react';
 
-import ProjectCard from '../components/projects/ProjectCard';
-import HorizontalLine from '../components/HorizontalLine';
-import projectsDetail from '../assets/projects.json';
-import ProjectSearch from '../components/projects/ProjectSearch';
+import ProjectCard from '../../components/projects/ProjectCard';
+import projectsDetail from '../../assets/projects.json';
 
 const Projects = () => {
   return (
-    <div className="bg-white rounded-3xl h-full">
-      <div className="flex p-4">
-        <div className="grow mr-2">
-          <ProjectSearch onChange={() => {}} />
-        </div>
-        <IconButton color="blue" className="rounded-full mr-2">
-          <Typography variant="h5">+</Typography>
-        </IconButton>
-        <div className="mr-2 flex items-center">
-          <Typography>^</Typography>
-        </div>
-        <div className="px-2 py-1 bg-blue-gray-50 rounded-lg">
-          <Typography variant="lead">SY</Typography>
-        </div>
-      </div>
-      <HorizontalLine />
+    <div>
       <div className="flex p-5">
         <div className="grow">
           <div className="flex gap-2 items-center">
diff --git a/packages/frontend/src/pages/projects/routes.tsx b/packages/frontend/src/pages/projects/routes.tsx
index 9d450f10..e31eeef2 100644
--- a/packages/frontend/src/pages/projects/routes.tsx
+++ b/packages/frontend/src/pages/projects/routes.tsx
@@ -4,14 +4,17 @@ import CreateProject from './Create';
 import Project from './Project';
 import { createProjectRoutes } from './create/routes';
 
-export const projectsRoutes = [
-  {
-    path: ':id',
-    element: <Project />,
-  },
+export const projectsRoutesWithoutSearch = [
   {
     path: 'create',
     element: <CreateProject />,
     children: createProjectRoutes,
   },
 ];
+
+export const projectsRoutesWithSearch = [
+  {
+    path: ':id',
+    element: <Project />,
+  },
+];
diff --git a/packages/frontend/src/pages/routes.tsx b/packages/frontend/src/pages/routes.tsx
deleted file mode 100644
index 756b362e..00000000
--- a/packages/frontend/src/pages/routes.tsx
+++ /dev/null
@@ -1,20 +0,0 @@
-import React from 'react';
-
-import Projects from './Projects';
-import Settings from './Settings';
-import { projectsRoutes } from './projects/routes';
-
-export const homeRoutes = [
-  {
-    index: true,
-    element: <Projects />,
-  },
-  {
-    path: 'settings',
-    element: <Settings />,
-  },
-  {
-    path: 'projects',
-    children: projectsRoutes,
-  },
-];