Fix request id null issue when fetching deploy logs
All checks were successful
Lint / lint (20.x) (pull_request) Successful in 4m37s

This commit is contained in:
IshaVenikar 2024-11-12 15:32:53 +05:30
parent 4a9f517d85
commit 8ea91bbce1
3 changed files with 7 additions and 10 deletions

View File

@ -92,7 +92,7 @@ const DeploymentDetailsCard = ({
} }
}; };
const fetchDeploymentLogs = async () => { const fetchDeploymentLogs = useCallback(async () => {
setDeploymentLogs('Loading logs...'); setDeploymentLogs('Loading logs...');
handleOpenDialog(); handleOpenDialog();
const statusUrl = `${deployment.deployer.deployerApiUrl}/${deployment.applicationDeploymentRequestId}`; const statusUrl = `${deployment.deployer.deployerApiUrl}/${deployment.applicationDeploymentRequestId}`;
@ -108,7 +108,7 @@ const DeploymentDetailsCard = ({
); );
setDeploymentLogs(logsRes); setDeploymentLogs(logsRes);
} }
}; }, [deployment.deployer, deployment.applicationDeploymentRequestId]);
const renderDeploymentStatus = useCallback( const renderDeploymentStatus = useCallback(
(className?: string) => { (className?: string) => {
@ -127,7 +127,7 @@ const DeploymentDetailsCard = ({
</Tooltip> </Tooltip>
); );
}, },
[deployment.status, deployment.commitHash], [deployment.status, deployment.commitHash, fetchDeploymentLogs],
); );
return ( return (

View File

@ -4,10 +4,7 @@ import { cloneIcon } from 'utils/cloneIcon';
import { PWAIcon } from './PWAIcon'; import { PWAIcon } from './PWAIcon';
import { WebAppIcon } from './WebAppIcon'; import { WebAppIcon } from './WebAppIcon';
const TEMPLATE_ICONS = [ const TEMPLATE_ICONS = ['pwa', 'web'] as const;
'pwa',
'web'
] as const;
export type TemplateIconType = (typeof TEMPLATE_ICONS)[number]; export type TemplateIconType = (typeof TEMPLATE_ICONS)[number];
export interface TemplateIconProps extends CustomIconProps { export interface TemplateIconProps extends CustomIconProps {

View File

@ -73,17 +73,17 @@ const EnvironmentVariablesForm = () => {
<div className="flex gap-2 p-2"> <div className="flex gap-2 p-2">
<Checkbox <Checkbox
label="Production" label="Production"
labelProps={{ className: "text-gray-900 dark:text-white" }} labelProps={{ className: 'text-gray-900 dark:text-white' }}
{...register('environment.production')} {...register('environment.production')}
/> />
<Checkbox <Checkbox
label="Preview" label="Preview"
labelProps={{ className: "text-gray-900 dark:text-white" }} labelProps={{ className: 'text-gray-900 dark:text-white' }}
{...register('environment.preview')} {...register('environment.preview')}
/> />
<Checkbox <Checkbox
label="Development" label="Development"
labelProps={{ className: "text-gray-900 dark:text-white" }} labelProps={{ className: 'text-gray-900 dark:text-white' }}
{...register('environment.development')} {...register('environment.development')}
/> />
</div> </div>