cerc-io/snowballtools-base-mirror
16
0
Fork 0
mirror of https://github.com/snowball-tools/snowballtools-base.git synced 2024-11-17 16:29:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

♻️ refactor: update pr review

Browse Source
This commit is contained in:
Wahyu Kurniawan 2024-02-27 11:36:14 +07:00
parent 1e056d7969
commit fcaeabf07d
No known key found for this signature in database
GPG Key ID: 040A1549143A8E33
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/frontend/src/components/shared/Select/SelectItem/SelectItem.tsx
View File

@ -48,7 +48,7 @@ const SelectItem = forwardRef<HTMLLIElement, SelectItemProps>(
); );
} }
return null; return null;
}, [rightIcon]); }, [rightIcon, theme, cloneIcon, cn, selected]);
return ( return (
<li <li

11
packages/frontend/src/pages/components/index.tsx
View File

@ -1,9 +1,11 @@
import React, { useState } from 'react'; import React from 'react';
import { Calendar } from 'components/shared/Calendar'; import { Calendar } from 'components/shared/Calendar';
import { DatePicker } from 'components/shared/DatePicker'; import { DatePicker } from 'components/shared/DatePicker';
import { Radio } from 'components/shared/Radio'; import { Radio } from 'components/shared/Radio';
import { SegmentedControls } from 'components/shared/SegmentedControls'; import { SegmentedControls } from 'components/shared/SegmentedControls';
import { Switch } from 'components/shared/Switch'; import { Switch } from 'components/shared/Switch';
import { useState } from 'react';
import { Value } from 'react-calendar/dist/cjs/shared/types';
import { avatars, avatarsFallback } from './renders/avatar'; import { avatars, avatarsFallback } from './renders/avatar';
import { renderBadges } from './renders/badge'; import { renderBadges } from './renders/badge';
import { import {
@ -16,6 +18,7 @@ import {
renderCheckbox, renderCheckbox,
renderCheckboxWithDescription, renderCheckboxWithDescription,
} from './renders/checkbox'; } from './renders/checkbox';
import { DropdownExample } from './renders/dropdown';
import { import {
renderInlineNotificationWithDescriptions, renderInlineNotificationWithDescriptions,
renderInlineNotifications, renderInlineNotifications,
@ -31,10 +34,6 @@ import {
import { renderDefaultTag, renderMinimalTag } from './renders/tag'; import { renderDefaultTag, renderMinimalTag } from './renders/tag';
import { renderToast, renderToastsWithCta } from './renders/toast'; import { renderToast, renderToastsWithCta } from './renders/toast';
import { renderTooltips } from './renders/tooltip'; import { renderTooltips } from './renders/tooltip';
import { DropdownExample } from './renders/dropdown';
type ValuePiece = Date | null;
type Value = ValuePiece | [ValuePiece, ValuePiece];
const Page: React.FC = () => { const Page: React.FC = () => {
const [singleDate, setSingleDate] = useState<Value>(); const [singleDate, setSingleDate] = useState<Value>();
@ -274,7 +273,7 @@ const Page: React.FC = () => {
{/* Dropdown */} {/* Dropdown */}
<div className="flex flex-col gap-10 items-center justify-between"> <div className="flex flex-col gap-10 items-center justify-between">
<h1 className="text-2xl font-bold">Dropdown / Select</h1> <h1 className="text-2xl font-bold">Dropdown / Select</h1>
{<DropdownExample />} <DropdownExample />
</div> </div>
<div className="w-full h border border-gray-200 px-20 my-10" /> <div className="w-full h border border-gray-200 px-20 my-10" />