cerc-io/registry-sdk
17
0
Fork 2
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases 11 Wiki Activity

globalThis incorrectly pollyfilled #23

New Issue
Open
opened 2024-08-27 19:30:43 +00:00 by gilbert · 3 comments
gilbert commented 2024-08-27 19:30:43 +00:00
Contributor
Copy Link

In registry.ts, globalThis is incorrectly polyfilled, which causes it to choose a different global instead of an already-present globalThis.

Namely, the act of declaring var globalThis shadows the actual globalThis, causing globalThis to be undefined within the IIFE.

This becomes an issue in node.js server-side rendering environments where window is polyfilled, and node's globalThis has different functions than window does.

Suggested fixes:

  1. Rename the variable to something else, or
  2. Just use globalThis without attempting to polyfill. LTS versions of node support it, and versions as far back as v12 (released in 2019).
In [registry.ts](https://git.vdb.to/cerc-io/registry-sdk/src/commit/f93a29785704e8c154a4256e8afd6143a8b7efea/src/proto/cerc/registry/v1/registry.ts#L1165-L1171), globalThis is incorrectly polyfilled, which causes it to choose a different global instead of an already-present `globalThis`. Namely, the act of declaring `var globalThis` shadows the actual `globalThis`, causing `globalThis` to be undefined within the IIFE. This becomes an issue in node.js server-side rendering environments where `window` is polyfilled, and node's `globalThis` has different functions than `window` does. Suggested fixes: 1. Rename the variable to something else, or 2. Just use `globalThis` without attempting to polyfill. LTS versions of node support it, and versions as far back as v12 (released in 2019).
gilbert commented 2024-08-27 19:54:55 +00:00
Author
Contributor
Copy Link

See this code example for an illustration of the issue.

See [this code example](https://jsbin.com/cotehupazu/edit?js,console) for an illustration of the issue.
zramsay commented 2024-08-27 23:39:47 +00:00
Member
Copy Link

re-opening b/c this patch needs to be applied to main. cut patch release to unblock progress on snowball

re-opening b/c this patch needs to be applied to main. cut patch release to unblock progress on snowball
zramsay reopened this issue 2024-08-27 23:39:47 +00:00
ashwin was assigned by zramsay 2024-08-27 23:39:56 +00:00
prathamesh commented 2024-08-28 11:52:31 +00:00
Member
Copy Link

re-opening b/c this patch needs to be applied to main. cut patch release to unblock progress on snowball

Handled in #25
Included in release v0.2.7

> re-opening b/c this patch needs to be applied to main. cut patch release to unblock progress on snowball Handled in #25 Included in release [v0.2.7](https://git.vdb.to/cerc-io/registry-sdk/releases/tag/v0.2.7)
🎉 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
ashwin
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/registry-sdk#23
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?