8d066f1f42
This commit replaces ioutil.TempDir with t.TempDir in tests. The directory created by t.TempDir is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using ioutil.TempDir had to be removed manually by calling os.RemoveAll, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but t.TempDir handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
158 lines
5.2 KiB
Go
158 lines
5.2 KiB
Go
// Copyright 2015 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package node
|
|
|
|
import (
|
|
"bytes"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"github.com/ethereum/go-ethereum/crypto"
|
|
"github.com/ethereum/go-ethereum/p2p"
|
|
)
|
|
|
|
// Tests that datadirs can be successfully created, be them manually configured
|
|
// ones or automatically generated temporary ones.
|
|
func TestDatadirCreation(t *testing.T) {
|
|
// Create a temporary data dir and check that it can be used by a node
|
|
dir := t.TempDir()
|
|
|
|
node, err := New(&Config{DataDir: dir})
|
|
if err != nil {
|
|
t.Fatalf("failed to create stack with existing datadir: %v", err)
|
|
}
|
|
if err := node.Close(); err != nil {
|
|
t.Fatalf("failed to close node: %v", err)
|
|
}
|
|
// Generate a long non-existing datadir path and check that it gets created by a node
|
|
dir = filepath.Join(dir, "a", "b", "c", "d", "e", "f")
|
|
node, err = New(&Config{DataDir: dir})
|
|
if err != nil {
|
|
t.Fatalf("failed to create stack with creatable datadir: %v", err)
|
|
}
|
|
if err := node.Close(); err != nil {
|
|
t.Fatalf("failed to close node: %v", err)
|
|
}
|
|
if _, err := os.Stat(dir); err != nil {
|
|
t.Fatalf("freshly created datadir not accessible: %v", err)
|
|
}
|
|
// Verify that an impossible datadir fails creation
|
|
file, err := ioutil.TempFile("", "")
|
|
if err != nil {
|
|
t.Fatalf("failed to create temporary file: %v", err)
|
|
}
|
|
defer func() {
|
|
file.Close()
|
|
os.Remove(file.Name())
|
|
}()
|
|
|
|
dir = filepath.Join(file.Name(), "invalid/path")
|
|
node, err = New(&Config{DataDir: dir})
|
|
if err == nil {
|
|
t.Fatalf("protocol stack created with an invalid datadir")
|
|
if err := node.Close(); err != nil {
|
|
t.Fatalf("failed to close node: %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests that IPC paths are correctly resolved to valid endpoints of different
|
|
// platforms.
|
|
func TestIPCPathResolution(t *testing.T) {
|
|
var tests = []struct {
|
|
DataDir string
|
|
IPCPath string
|
|
Windows bool
|
|
Endpoint string
|
|
}{
|
|
{"", "", false, ""},
|
|
{"data", "", false, ""},
|
|
{"", "geth.ipc", false, filepath.Join(os.TempDir(), "geth.ipc")},
|
|
{"data", "geth.ipc", false, "data/geth.ipc"},
|
|
{"data", "./geth.ipc", false, "./geth.ipc"},
|
|
{"data", "/geth.ipc", false, "/geth.ipc"},
|
|
{"", "", true, ``},
|
|
{"data", "", true, ``},
|
|
{"", "geth.ipc", true, `\\.\pipe\geth.ipc`},
|
|
{"data", "geth.ipc", true, `\\.\pipe\geth.ipc`},
|
|
{"data", `\\.\pipe\geth.ipc`, true, `\\.\pipe\geth.ipc`},
|
|
}
|
|
for i, test := range tests {
|
|
// Only run when platform/test match
|
|
if (runtime.GOOS == "windows") == test.Windows {
|
|
if endpoint := (&Config{DataDir: test.DataDir, IPCPath: test.IPCPath}).IPCEndpoint(); endpoint != test.Endpoint {
|
|
t.Errorf("test %d: IPC endpoint mismatch: have %s, want %s", i, endpoint, test.Endpoint)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Tests that node keys can be correctly created, persisted, loaded and/or made
|
|
// ephemeral.
|
|
func TestNodeKeyPersistency(t *testing.T) {
|
|
// Create a temporary folder and make sure no key is present
|
|
dir := t.TempDir()
|
|
|
|
keyfile := filepath.Join(dir, "unit-test", datadirPrivateKey)
|
|
|
|
// Configure a node with a preset key and ensure it's not persisted
|
|
key, err := crypto.GenerateKey()
|
|
if err != nil {
|
|
t.Fatalf("failed to generate one-shot node key: %v", err)
|
|
}
|
|
config := &Config{Name: "unit-test", DataDir: dir, P2P: p2p.Config{PrivateKey: key}}
|
|
config.NodeKey()
|
|
if _, err := os.Stat(filepath.Join(keyfile)); err == nil {
|
|
t.Fatalf("one-shot node key persisted to data directory")
|
|
}
|
|
|
|
// Configure a node with no preset key and ensure it is persisted this time
|
|
config = &Config{Name: "unit-test", DataDir: dir}
|
|
config.NodeKey()
|
|
if _, err := os.Stat(keyfile); err != nil {
|
|
t.Fatalf("node key not persisted to data directory: %v", err)
|
|
}
|
|
if _, err = crypto.LoadECDSA(keyfile); err != nil {
|
|
t.Fatalf("failed to load freshly persisted node key: %v", err)
|
|
}
|
|
blob1, err := ioutil.ReadFile(keyfile)
|
|
if err != nil {
|
|
t.Fatalf("failed to read freshly persisted node key: %v", err)
|
|
}
|
|
|
|
// Configure a new node and ensure the previously persisted key is loaded
|
|
config = &Config{Name: "unit-test", DataDir: dir}
|
|
config.NodeKey()
|
|
blob2, err := ioutil.ReadFile(filepath.Join(keyfile))
|
|
if err != nil {
|
|
t.Fatalf("failed to read previously persisted node key: %v", err)
|
|
}
|
|
if !bytes.Equal(blob1, blob2) {
|
|
t.Fatalf("persisted node key mismatch: have %x, want %x", blob2, blob1)
|
|
}
|
|
|
|
// Configure ephemeral node and ensure no key is dumped locally
|
|
config = &Config{Name: "unit-test", DataDir: ""}
|
|
config.NodeKey()
|
|
if _, err := os.Stat(filepath.Join(".", "unit-test", datadirPrivateKey)); err == nil {
|
|
t.Fatalf("ephemeral node key persisted to disk")
|
|
}
|
|
}
|