295693759e
* core/vm/runtime/tests: add more benchmarks * core/vm: initial work on improving alloc count for calls to precompiles name old time/op new time/op delta SimpleLoop/identity-precompile-10M-6 117ms ±75% 43ms ± 1% -63.09% (p=0.008 n=5+5) SimpleLoop/loop-10M-6 79.6ms ± 4% 70.5ms ± 1% -11.42% (p=0.008 n=5+5) name old alloc/op new alloc/op delta SimpleLoop/identity-precompile-10M-6 24.4MB ± 0% 4.9MB ± 0% -79.94% (p=0.008 n=5+5) SimpleLoop/loop-10M-6 13.2kB ± 0% 13.2kB ± 0% ~ (p=0.357 n=5+5) name old allocs/op new allocs/op delta SimpleLoop/identity-precompile-10M-6 382k ± 0% 153k ± 0% -59.99% (p=0.000 n=5+4) SimpleLoop/loop-10M-6 40.0 ± 0% 40.0 ± 0% ~ (all equal) * core/vm: don't allocate big.int for touch name old time/op new time/op delta SimpleLoop/identity-precompile-10M-6 43.3ms ± 1% 42.4ms ± 7% ~ (p=0.151 n=5+5) SimpleLoop/loop-10M-6 70.5ms ± 1% 76.7ms ± 1% +8.67% (p=0.008 n=5+5) name old alloc/op new alloc/op delta SimpleLoop/identity-precompile-10M-6 4.90MB ± 0% 2.46MB ± 0% -49.83% (p=0.008 n=5+5) SimpleLoop/loop-10M-6 13.2kB ± 0% 13.2kB ± 1% ~ (p=0.571 n=5+5) name old allocs/op new allocs/op delta SimpleLoop/identity-precompile-10M-6 153k ± 0% 76k ± 0% -49.98% (p=0.029 n=4+4) SimpleLoop/loop-10M-6 40.0 ± 0% 40.0 ± 0% ~ (all equal) * core/vm: reduce allocs in staticcall name old time/op new time/op delta SimpleLoop/identity-precompile-10M-6 42.4ms ± 7% 37.5ms ± 6% -11.68% (p=0.008 n=5+5) SimpleLoop/loop-10M-6 76.7ms ± 1% 69.1ms ± 1% -9.82% (p=0.008 n=5+5) name old alloc/op new alloc/op delta SimpleLoop/identity-precompile-10M-6 2.46MB ± 0% 0.02MB ± 0% -99.35% (p=0.008 n=5+5) SimpleLoop/loop-10M-6 13.2kB ± 1% 13.2kB ± 0% ~ (p=0.143 n=5+5) name old allocs/op new allocs/op delta SimpleLoop/identity-precompile-10M-6 76.4k ± 0% 0.1k ± 0% ~ (p=0.079 n=4+5) SimpleLoop/loop-10M-6 40.0 ± 0% 40.0 ± 0% ~ (all equal) * trie: better use of hasher keccakState * core/state/statedb: reduce allocations in getDeletedStateObject * core/vm: reduce allocations in all call derivates * core/vm: reduce allocations in call variants - Make returnstack `uint32` - Use a `sync.Pool` of `stack`s * core/vm: fix tests * core/vm: goimports * core/vm: tracer fix + staticcall gas fix * core/vm: add back snapshot to staticcall * core/vm: review concerns + make returnstack pooled + enable returndata in traces * core/vm: fix some test tracer method signatures * core/vm: run gencodec, minor comment polish Co-authored-by: Péter Szilágyi <peterke@gmail.com>
132 lines
3.1 KiB
Go
132 lines
3.1 KiB
Go
// Copyright 2014 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package vm
|
|
|
|
import (
|
|
"fmt"
|
|
"sync"
|
|
|
|
"github.com/holiman/uint256"
|
|
)
|
|
|
|
var stackPool = sync.Pool{
|
|
New: func() interface{} {
|
|
return &Stack{data: make([]uint256.Int, 0, 16)}
|
|
},
|
|
}
|
|
|
|
// Stack is an object for basic stack operations. Items popped to the stack are
|
|
// expected to be changed and modified. stack does not take care of adding newly
|
|
// initialised objects.
|
|
type Stack struct {
|
|
data []uint256.Int
|
|
}
|
|
|
|
func newstack() *Stack {
|
|
return stackPool.Get().(*Stack)
|
|
}
|
|
|
|
func returnStack(s *Stack) {
|
|
s.data = s.data[:0]
|
|
stackPool.Put(s)
|
|
}
|
|
|
|
// Data returns the underlying uint256.Int array.
|
|
func (st *Stack) Data() []uint256.Int {
|
|
return st.data
|
|
}
|
|
|
|
func (st *Stack) push(d *uint256.Int) {
|
|
// NOTE push limit (1024) is checked in baseCheck
|
|
st.data = append(st.data, *d)
|
|
}
|
|
func (st *Stack) pushN(ds ...uint256.Int) {
|
|
// FIXME: Is there a way to pass args by pointers.
|
|
st.data = append(st.data, ds...)
|
|
}
|
|
|
|
func (st *Stack) pop() (ret uint256.Int) {
|
|
ret = st.data[len(st.data)-1]
|
|
st.data = st.data[:len(st.data)-1]
|
|
return
|
|
}
|
|
|
|
func (st *Stack) len() int {
|
|
return len(st.data)
|
|
}
|
|
|
|
func (st *Stack) swap(n int) {
|
|
st.data[st.len()-n], st.data[st.len()-1] = st.data[st.len()-1], st.data[st.len()-n]
|
|
}
|
|
|
|
func (st *Stack) dup(n int) {
|
|
st.push(&st.data[st.len()-n])
|
|
}
|
|
|
|
func (st *Stack) peek() *uint256.Int {
|
|
return &st.data[st.len()-1]
|
|
}
|
|
|
|
// Back returns the n'th item in stack
|
|
func (st *Stack) Back(n int) *uint256.Int {
|
|
return &st.data[st.len()-n-1]
|
|
}
|
|
|
|
// Print dumps the content of the stack
|
|
func (st *Stack) Print() {
|
|
fmt.Println("### stack ###")
|
|
if len(st.data) > 0 {
|
|
for i, val := range st.data {
|
|
fmt.Printf("%-3d %v\n", i, val)
|
|
}
|
|
} else {
|
|
fmt.Println("-- empty --")
|
|
}
|
|
fmt.Println("#############")
|
|
}
|
|
|
|
var rStackPool = sync.Pool{
|
|
New: func() interface{} {
|
|
return &ReturnStack{data: make([]uint32, 0, 10)}
|
|
},
|
|
}
|
|
|
|
// ReturnStack is an object for basic return stack operations.
|
|
type ReturnStack struct {
|
|
data []uint32
|
|
}
|
|
|
|
func newReturnStack() *ReturnStack {
|
|
return rStackPool.Get().(*ReturnStack)
|
|
}
|
|
|
|
func returnRStack(rs *ReturnStack) {
|
|
rs.data = rs.data[:0]
|
|
rStackPool.Put(rs)
|
|
}
|
|
|
|
func (st *ReturnStack) push(d uint32) {
|
|
st.data = append(st.data, d)
|
|
}
|
|
|
|
// A uint32 is sufficient as for code below 4.2G
|
|
func (st *ReturnStack) pop() (ret uint32) {
|
|
ret = st.data[len(st.data)-1]
|
|
st.data = st.data[:len(st.data)-1]
|
|
return
|
|
}
|