ddeea1e0c6
* core, crypto: various allocation savings regarding tx handling * core: reduce allocs for gas price comparison This change reduces the allocations needed for comparing different transactions to each other. A call to `tx.GasPrice()` copies the gas price as it has to be safe against modifications and also needs to be threadsafe. For comparing and ordering different transactions we don't need these guarantees * core: added tx.GasPriceIntCmp for comparison without allocation adds a method to remove unneeded allocation in comparison to tx.gasPrice * core/types: pool legacykeccak256 objects in rlpHash rlpHash is by far the most used function in core that allocates a legacyKeccak256 object on each call. Since it is so widely used it makes sense to add pooling here so we relieve the GC. On my machine these changes result in > 100 MILLION less allocations and > 30 GB less allocated memory. * reverted some changes * reverted some changes * trie: use crypto.KeccakState instead of replicating code Co-authored-by: Martin Holst Swende <martin@swende.se>
71 lines
2.3 KiB
Go
71 lines
2.3 KiB
Go
// Copyright 2016 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package core
|
|
|
|
import (
|
|
"math/big"
|
|
"math/rand"
|
|
"testing"
|
|
|
|
"github.com/ethereum/go-ethereum/core/types"
|
|
"github.com/ethereum/go-ethereum/crypto"
|
|
)
|
|
|
|
// Tests that transactions can be added to strict lists and list contents and
|
|
// nonce boundaries are correctly maintained.
|
|
func TestStrictTxListAdd(t *testing.T) {
|
|
// Generate a list of transactions to insert
|
|
key, _ := crypto.GenerateKey()
|
|
|
|
txs := make(types.Transactions, 1024)
|
|
for i := 0; i < len(txs); i++ {
|
|
txs[i] = transaction(uint64(i), 0, key)
|
|
}
|
|
// Insert the transactions in a random order
|
|
list := newTxList(true)
|
|
for _, v := range rand.Perm(len(txs)) {
|
|
list.Add(txs[v], DefaultTxPoolConfig.PriceBump)
|
|
}
|
|
// Verify internal state
|
|
if len(list.txs.items) != len(txs) {
|
|
t.Errorf("transaction count mismatch: have %d, want %d", len(list.txs.items), len(txs))
|
|
}
|
|
for i, tx := range txs {
|
|
if list.txs.items[tx.Nonce()] != tx {
|
|
t.Errorf("item %d: transaction mismatch: have %v, want %v", i, list.txs.items[tx.Nonce()], tx)
|
|
}
|
|
}
|
|
}
|
|
|
|
func BenchmarkTxListAdd(t *testing.B) {
|
|
// Generate a list of transactions to insert
|
|
key, _ := crypto.GenerateKey()
|
|
|
|
txs := make(types.Transactions, 100000)
|
|
for i := 0; i < len(txs); i++ {
|
|
txs[i] = transaction(uint64(i), 0, key)
|
|
}
|
|
// Insert the transactions in a random order
|
|
list := newTxList(true)
|
|
priceLimit := big.NewInt(int64(DefaultTxPoolConfig.PriceLimit))
|
|
t.ResetTimer()
|
|
for _, v := range rand.Perm(len(txs)) {
|
|
list.Add(txs[v], DefaultTxPoolConfig.PriceBump)
|
|
list.Filter(priceLimit, DefaultTxPoolConfig.PriceBump)
|
|
}
|
|
}
|