4d3525610e
This PR is a (superior) alternative to https://github.com/ethereum/go-ethereum/pull/26708, it handles deprecation, primarily two specific cases. `rand.Seed` is typically used in two ways - `rand.Seed(time.Now().UnixNano())` -- we seed it, just to be sure to get some random, and not always get the same thing on every run. This is not needed, with global seeding, so those are just removed. - `rand.Seed(1)` this is typically done to ensure we have a stable test. If we rely on this, we need to fix up the tests to use a deterministic prng-source. A few occurrences like this has been replaced with a proper custom source. `rand.Read` has been replaced by `crypto/rand`.`Read` in this PR.
242 lines
5.2 KiB
Go
242 lines
5.2 KiB
Go
// Copyright 2022 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package lru
|
|
|
|
import (
|
|
crand "crypto/rand"
|
|
"fmt"
|
|
"io"
|
|
"math/rand"
|
|
"testing"
|
|
)
|
|
|
|
// Some of these test cases were adapted
|
|
// from https://github.com/hashicorp/golang-lru/blob/master/simplelru/lru_test.go
|
|
|
|
func TestBasicLRU(t *testing.T) {
|
|
cache := NewBasicLRU[int, int](128)
|
|
|
|
for i := 0; i < 256; i++ {
|
|
cache.Add(i, i)
|
|
}
|
|
if cache.Len() != 128 {
|
|
t.Fatalf("bad len: %v", cache.Len())
|
|
}
|
|
|
|
// Check that Keys returns least-recent key first.
|
|
keys := cache.Keys()
|
|
if len(keys) != 128 {
|
|
t.Fatal("wrong Keys() length", len(keys))
|
|
}
|
|
for i, k := range keys {
|
|
v, ok := cache.Peek(k)
|
|
if !ok {
|
|
t.Fatalf("expected key %d be present", i)
|
|
}
|
|
if v != k {
|
|
t.Fatalf("expected %d == %d", k, v)
|
|
}
|
|
if v != i+128 {
|
|
t.Fatalf("wrong value at key %d: %d, want %d", i, v, i+128)
|
|
}
|
|
}
|
|
|
|
for i := 0; i < 128; i++ {
|
|
_, ok := cache.Get(i)
|
|
if ok {
|
|
t.Fatalf("%d should be evicted", i)
|
|
}
|
|
}
|
|
for i := 128; i < 256; i++ {
|
|
_, ok := cache.Get(i)
|
|
if !ok {
|
|
t.Fatalf("%d should not be evicted", i)
|
|
}
|
|
}
|
|
|
|
for i := 128; i < 192; i++ {
|
|
ok := cache.Remove(i)
|
|
if !ok {
|
|
t.Fatalf("%d should be in cache", i)
|
|
}
|
|
ok = cache.Remove(i)
|
|
if ok {
|
|
t.Fatalf("%d should not be in cache", i)
|
|
}
|
|
_, ok = cache.Get(i)
|
|
if ok {
|
|
t.Fatalf("%d should be deleted", i)
|
|
}
|
|
}
|
|
|
|
// Request item 192.
|
|
cache.Get(192)
|
|
// It should be the last item returned by Keys().
|
|
for i, k := range cache.Keys() {
|
|
if (i < 63 && k != i+193) || (i == 63 && k != 192) {
|
|
t.Fatalf("out of order key: %v", k)
|
|
}
|
|
}
|
|
|
|
cache.Purge()
|
|
if cache.Len() != 0 {
|
|
t.Fatalf("bad len: %v", cache.Len())
|
|
}
|
|
if _, ok := cache.Get(200); ok {
|
|
t.Fatalf("should contain nothing")
|
|
}
|
|
}
|
|
|
|
func TestBasicLRUAddExistingKey(t *testing.T) {
|
|
cache := NewBasicLRU[int, int](1)
|
|
|
|
cache.Add(1, 1)
|
|
cache.Add(1, 2)
|
|
|
|
v, _ := cache.Get(1)
|
|
if v != 2 {
|
|
t.Fatal("wrong value:", v)
|
|
}
|
|
}
|
|
|
|
// This test checks GetOldest and RemoveOldest.
|
|
func TestBasicLRUGetOldest(t *testing.T) {
|
|
cache := NewBasicLRU[int, int](128)
|
|
for i := 0; i < 256; i++ {
|
|
cache.Add(i, i)
|
|
}
|
|
|
|
k, _, ok := cache.GetOldest()
|
|
if !ok {
|
|
t.Fatalf("missing")
|
|
}
|
|
if k != 128 {
|
|
t.Fatalf("bad: %v", k)
|
|
}
|
|
|
|
k, _, ok = cache.RemoveOldest()
|
|
if !ok {
|
|
t.Fatalf("missing")
|
|
}
|
|
if k != 128 {
|
|
t.Fatalf("bad: %v", k)
|
|
}
|
|
|
|
k, _, ok = cache.RemoveOldest()
|
|
if !ok {
|
|
t.Fatalf("missing oldest item")
|
|
}
|
|
if k != 129 {
|
|
t.Fatalf("wrong oldest item: %v", k)
|
|
}
|
|
}
|
|
|
|
// Test that Add returns true/false if an eviction occurred
|
|
func TestBasicLRUAddReturnValue(t *testing.T) {
|
|
cache := NewBasicLRU[int, int](1)
|
|
if cache.Add(1, 1) {
|
|
t.Errorf("first add shouldn't have evicted")
|
|
}
|
|
if !cache.Add(2, 2) {
|
|
t.Errorf("second add should have evicted")
|
|
}
|
|
}
|
|
|
|
// This test verifies that Contains doesn't change item recency.
|
|
func TestBasicLRUContains(t *testing.T) {
|
|
cache := NewBasicLRU[int, int](2)
|
|
cache.Add(1, 1)
|
|
cache.Add(2, 2)
|
|
if !cache.Contains(1) {
|
|
t.Errorf("1 should be in the cache")
|
|
}
|
|
cache.Add(3, 3)
|
|
if cache.Contains(1) {
|
|
t.Errorf("Contains should not have updated recency of 1")
|
|
}
|
|
}
|
|
|
|
func BenchmarkLRU(b *testing.B) {
|
|
var (
|
|
capacity = 1000
|
|
indexes = make([]int, capacity*20)
|
|
keys = make([]string, capacity)
|
|
values = make([][]byte, capacity)
|
|
)
|
|
for i := range indexes {
|
|
indexes[i] = rand.Intn(capacity)
|
|
}
|
|
for i := range keys {
|
|
b := make([]byte, 32)
|
|
crand.Read(b)
|
|
keys[i] = string(b)
|
|
crand.Read(b)
|
|
values[i] = b
|
|
}
|
|
|
|
var sink []byte
|
|
|
|
b.Run("Add/BasicLRU", func(b *testing.B) {
|
|
cache := NewBasicLRU[int, int](capacity)
|
|
for i := 0; i < b.N; i++ {
|
|
cache.Add(i, i)
|
|
}
|
|
})
|
|
b.Run("Get/BasicLRU", func(b *testing.B) {
|
|
cache := NewBasicLRU[string, []byte](capacity)
|
|
for i := 0; i < capacity; i++ {
|
|
index := indexes[i]
|
|
cache.Add(keys[index], values[index])
|
|
}
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
k := keys[indexes[i%len(indexes)]]
|
|
v, ok := cache.Get(k)
|
|
if ok {
|
|
sink = v
|
|
}
|
|
}
|
|
})
|
|
|
|
// // vs. github.com/hashicorp/golang-lru/simplelru
|
|
// b.Run("Add/simplelru.LRU", func(b *testing.B) {
|
|
// cache, _ := simplelru.NewLRU(capacity, nil)
|
|
// for i := 0; i < b.N; i++ {
|
|
// cache.Add(i, i)
|
|
// }
|
|
// })
|
|
// b.Run("Get/simplelru.LRU", func(b *testing.B) {
|
|
// cache, _ := simplelru.NewLRU(capacity, nil)
|
|
// for i := 0; i < capacity; i++ {
|
|
// index := indexes[i]
|
|
// cache.Add(keys[index], values[index])
|
|
// }
|
|
//
|
|
// b.ResetTimer()
|
|
// for i := 0; i < b.N; i++ {
|
|
// k := keys[indexes[i%len(indexes)]]
|
|
// v, ok := cache.Get(k)
|
|
// if ok {
|
|
// sink = v.([]byte)
|
|
// }
|
|
// }
|
|
// })
|
|
|
|
fmt.Fprintln(io.Discard, sink)
|
|
}
|