plugeth/accounts
Marius van der Wijden ac9c03f910
accounts/abi: Prevent recalculation of internal fields (#20895)
* accounts/abi: prevent recalculation of ID, Sig and String

* accounts/abi: fixed unpacking of no values

* accounts/abi: multiple fixes to arguments

* accounts/abi: refactored methodName and eventName

This commit moves the complicated logic of how we assign method names
and event names if they already exist into their own functions for
better readability.

* accounts/abi: prevent recalculation of internal

In this commit, I changed the way we calculate the string
representations, sig representations and the id's of methods. Before
that these fields would be recalculated everytime someone called .Sig()
.String() or .ID() on a method or an event.

Additionally this commit fixes issue #20856 as we assign names to inputs
with no name (input with name "" becomes "arg0")

* accounts/abi: added unnamed event params test

* accounts/abi: fixed rebasing errors in method sig

* accounts/abi: fixed rebasing errors in method sig

* accounts/abi: addressed comments

* accounts/abi: added FunctionType enumeration

* accounts/abi/bind: added test for unnamed arguments

* accounts/abi: improved readability in NewMethod, nitpicks

* accounts/abi: method/eventName -> overloadedMethodName
2020-04-20 09:01:04 +02:00
..
abi accounts/abi: Prevent recalculation of internal fields (#20895) 2020-04-20 09:01:04 +02:00
external all: replace passPHRASE with passWORD in user interactions (#19932) 2019-08-12 12:00:38 +03:00
keystore accounts/keystore: fix staticcheck warnings (#20373) 2019-11-25 14:39:55 +01:00
scwallet build: upgrade to golangci-lint 1.24.0 (#20901) 2020-04-08 11:07:29 +03:00
usbwallet accounts/usbwallet: fix staticcheck warnings (#20372) 2019-11-29 11:47:14 +01:00
accounts_test.go all: update author list and licenses 2019-07-22 12:17:27 +03:00
accounts.go accounts,signer: better support for EIP-191 intended validator (#19523) 2019-05-15 21:26:07 +02:00
errors.go all: replace passPHRASE with passWORD in user interactions (#19932) 2019-08-12 12:00:38 +03:00
hd_test.go accounts: refactor API for generalized USB wallets 2017-08-09 13:26:07 +03:00
hd.go accounts: switch Ledger derivation path to canonical one 2019-04-10 13:09:08 +03:00
manager.go accounts: add walletsNoLock to avoid double read lock (#20655) 2020-02-12 15:20:50 +01:00
sort.go accounts, console: frendly card errors, support pin unblock 2019-04-08 13:19:37 +02:00
url_test.go all: update author list and licenses 2019-07-22 12:17:27 +03:00
url.go accounts: add unit tests for URL (#17182) 2018-07-18 11:32:49 +03:00