0b814d32f8
* accounts/abi/bind: support for multi-dim arrays Also: - reduce usage of regexes a bit. - fix minor Java syntax problems Fixes #15648 * accounts/abi/bind: Add some more documentation * accounts/abi/bind: Improve code readability * accounts/abi: bugfix for unpacking nested arrays The code previously assumed the arrays/slices were always 1 level deep. While the packing supports nested arrays (!!!). The current code for unpacking doesn't return the "consumed" length, so this fix had to work around that by calculating it (i.e. packing and getting resulting length) after the unpacking of the array element. It's far from ideal, but unpacking behaviour is fixed now. * accounts/abi: Fix unpacking of nested arrays Removed the temporary workaround of packing to calculate size, which was incorrect for slice-like types anyway. Full size of nested arrays is used now. * accounts/abi: deeply nested array unpack test Test unpacking of an array nested more than one level. * accounts/abi: Add deeply nested array pack test Same as the deep nested array unpack test, but the other way around. * accounts/abi/bind: deeply nested arrays bind test Test the usage of bindings that were generated for methods with multi-dimensional (and not just a single extra dimension, like foo[2][3]) array arguments and returns. edit: trigger rebuild, CI failed to fetch linter module. * accounts/abi/bind: improve array binding wrapArray uses a regex now, and arrayBindingJava is improved. * accounts/abi: Improve naming of element size func The full step size for unpacking an array is now retrieved with "getFullElemSize". * accounts/abi: support nested nested array args Previously, the code only considered the outer-size of the array, ignoring the size of the contents. This was fine for most types, but nested arrays are packed directly into it, and count towards the total size. This resulted in arguments following a nested array to replicate some of the binary contents of the array. The fix: for arrays, calculate their complete contents size: count the arg.Type.Elem.Size when Elem is an Array, and repeat when their child is an array too, etc. The count is the number of 32 byte elements, similar to how it previously counted, but nested. * accounts/abi: Test deep nested arr multi-arguments Arguments with a deeply nested array should not cause the next arguments to be read from the wrong position.
231 lines
6.9 KiB
Go
231 lines
6.9 KiB
Go
// Copyright 2017 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package abi
|
|
|
|
import (
|
|
"encoding/binary"
|
|
"fmt"
|
|
"math/big"
|
|
"reflect"
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
)
|
|
|
|
// reads the integer based on its kind
|
|
func readInteger(kind reflect.Kind, b []byte) interface{} {
|
|
switch kind {
|
|
case reflect.Uint8:
|
|
return b[len(b)-1]
|
|
case reflect.Uint16:
|
|
return binary.BigEndian.Uint16(b[len(b)-2:])
|
|
case reflect.Uint32:
|
|
return binary.BigEndian.Uint32(b[len(b)-4:])
|
|
case reflect.Uint64:
|
|
return binary.BigEndian.Uint64(b[len(b)-8:])
|
|
case reflect.Int8:
|
|
return int8(b[len(b)-1])
|
|
case reflect.Int16:
|
|
return int16(binary.BigEndian.Uint16(b[len(b)-2:]))
|
|
case reflect.Int32:
|
|
return int32(binary.BigEndian.Uint32(b[len(b)-4:]))
|
|
case reflect.Int64:
|
|
return int64(binary.BigEndian.Uint64(b[len(b)-8:]))
|
|
default:
|
|
return new(big.Int).SetBytes(b)
|
|
}
|
|
}
|
|
|
|
// reads a bool
|
|
func readBool(word []byte) (bool, error) {
|
|
for _, b := range word[:31] {
|
|
if b != 0 {
|
|
return false, errBadBool
|
|
}
|
|
}
|
|
switch word[31] {
|
|
case 0:
|
|
return false, nil
|
|
case 1:
|
|
return true, nil
|
|
default:
|
|
return false, errBadBool
|
|
}
|
|
}
|
|
|
|
// A function type is simply the address with the function selection signature at the end.
|
|
// This enforces that standard by always presenting it as a 24-array (address + sig = 24 bytes)
|
|
func readFunctionType(t Type, word []byte) (funcTy [24]byte, err error) {
|
|
if t.T != FunctionTy {
|
|
return [24]byte{}, fmt.Errorf("abi: invalid type in call to make function type byte array")
|
|
}
|
|
if garbage := binary.BigEndian.Uint64(word[24:32]); garbage != 0 {
|
|
err = fmt.Errorf("abi: got improperly encoded function type, got %v", word)
|
|
} else {
|
|
copy(funcTy[:], word[0:24])
|
|
}
|
|
return
|
|
}
|
|
|
|
// through reflection, creates a fixed array to be read from
|
|
func readFixedBytes(t Type, word []byte) (interface{}, error) {
|
|
if t.T != FixedBytesTy {
|
|
return nil, fmt.Errorf("abi: invalid type in call to make fixed byte array")
|
|
}
|
|
// convert
|
|
array := reflect.New(t.Type).Elem()
|
|
|
|
reflect.Copy(array, reflect.ValueOf(word[0:t.Size]))
|
|
return array.Interface(), nil
|
|
|
|
}
|
|
|
|
func getFullElemSize(elem *Type) int {
|
|
//all other should be counted as 32 (slices have pointers to respective elements)
|
|
size := 32
|
|
//arrays wrap it, each element being the same size
|
|
for elem.T == ArrayTy {
|
|
size *= elem.Size
|
|
elem = elem.Elem
|
|
}
|
|
return size
|
|
}
|
|
|
|
// iteratively unpack elements
|
|
func forEachUnpack(t Type, output []byte, start, size int) (interface{}, error) {
|
|
if size < 0 {
|
|
return nil, fmt.Errorf("cannot marshal input to array, size is negative (%d)", size)
|
|
}
|
|
if start+32*size > len(output) {
|
|
return nil, fmt.Errorf("abi: cannot marshal in to go array: offset %d would go over slice boundary (len=%d)", len(output), start+32*size)
|
|
}
|
|
|
|
// this value will become our slice or our array, depending on the type
|
|
var refSlice reflect.Value
|
|
|
|
if t.T == SliceTy {
|
|
// declare our slice
|
|
refSlice = reflect.MakeSlice(t.Type, size, size)
|
|
} else if t.T == ArrayTy {
|
|
// declare our array
|
|
refSlice = reflect.New(t.Type).Elem()
|
|
} else {
|
|
return nil, fmt.Errorf("abi: invalid type in array/slice unpacking stage")
|
|
}
|
|
|
|
// Arrays have packed elements, resulting in longer unpack steps.
|
|
// Slices have just 32 bytes per element (pointing to the contents).
|
|
elemSize := 32
|
|
if t.T == ArrayTy {
|
|
elemSize = getFullElemSize(t.Elem)
|
|
}
|
|
|
|
for i, j := start, 0; j < size; i, j = i+elemSize, j+1 {
|
|
|
|
inter, err := toGoType(i, *t.Elem, output)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// append the item to our reflect slice
|
|
refSlice.Index(j).Set(reflect.ValueOf(inter))
|
|
}
|
|
|
|
// return the interface
|
|
return refSlice.Interface(), nil
|
|
}
|
|
|
|
// toGoType parses the output bytes and recursively assigns the value of these bytes
|
|
// into a go type with accordance with the ABI spec.
|
|
func toGoType(index int, t Type, output []byte) (interface{}, error) {
|
|
if index+32 > len(output) {
|
|
return nil, fmt.Errorf("abi: cannot marshal in to go type: length insufficient %d require %d", len(output), index+32)
|
|
}
|
|
|
|
var (
|
|
returnOutput []byte
|
|
begin, end int
|
|
err error
|
|
)
|
|
|
|
// if we require a length prefix, find the beginning word and size returned.
|
|
if t.requiresLengthPrefix() {
|
|
begin, end, err = lengthPrefixPointsTo(index, output)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
} else {
|
|
returnOutput = output[index : index+32]
|
|
}
|
|
|
|
switch t.T {
|
|
case SliceTy:
|
|
return forEachUnpack(t, output, begin, end)
|
|
case ArrayTy:
|
|
return forEachUnpack(t, output, index, t.Size)
|
|
case StringTy: // variable arrays are written at the end of the return bytes
|
|
return string(output[begin : begin+end]), nil
|
|
case IntTy, UintTy:
|
|
return readInteger(t.Kind, returnOutput), nil
|
|
case BoolTy:
|
|
return readBool(returnOutput)
|
|
case AddressTy:
|
|
return common.BytesToAddress(returnOutput), nil
|
|
case HashTy:
|
|
return common.BytesToHash(returnOutput), nil
|
|
case BytesTy:
|
|
return output[begin : begin+end], nil
|
|
case FixedBytesTy:
|
|
return readFixedBytes(t, returnOutput)
|
|
case FunctionTy:
|
|
return readFunctionType(t, returnOutput)
|
|
default:
|
|
return nil, fmt.Errorf("abi: unknown type %v", t.T)
|
|
}
|
|
}
|
|
|
|
// interprets a 32 byte slice as an offset and then determines which indice to look to decode the type.
|
|
func lengthPrefixPointsTo(index int, output []byte) (start int, length int, err error) {
|
|
bigOffsetEnd := big.NewInt(0).SetBytes(output[index : index+32])
|
|
bigOffsetEnd.Add(bigOffsetEnd, common.Big32)
|
|
outputLength := big.NewInt(int64(len(output)))
|
|
|
|
if bigOffsetEnd.Cmp(outputLength) > 0 {
|
|
return 0, 0, fmt.Errorf("abi: cannot marshal in to go slice: offset %v would go over slice boundary (len=%v)", bigOffsetEnd, outputLength)
|
|
}
|
|
|
|
if bigOffsetEnd.BitLen() > 63 {
|
|
return 0, 0, fmt.Errorf("abi offset larger than int64: %v", bigOffsetEnd)
|
|
}
|
|
|
|
offsetEnd := int(bigOffsetEnd.Uint64())
|
|
lengthBig := big.NewInt(0).SetBytes(output[offsetEnd-32 : offsetEnd])
|
|
|
|
totalSize := big.NewInt(0)
|
|
totalSize.Add(totalSize, bigOffsetEnd)
|
|
totalSize.Add(totalSize, lengthBig)
|
|
if totalSize.BitLen() > 63 {
|
|
return 0, 0, fmt.Errorf("abi length larger than int64: %v", totalSize)
|
|
}
|
|
|
|
if totalSize.Cmp(outputLength) > 0 {
|
|
return 0, 0, fmt.Errorf("abi: cannot marshal in to go type: length insufficient %v require %v", outputLength, totalSize)
|
|
}
|
|
start = int(bigOffsetEnd.Uint64())
|
|
length = int(lengthBig.Uint64())
|
|
return
|
|
}
|