be6078ad83
The leaks were mostly in unit tests, and could all be resolved by adding suitably-sized channel buffers or by restructuring the test to not send on a channel after an error has occurred. There is an unavoidable goroutine leak in Console.Interactive: when we receive a signal, the line reader cannot be unblocked and will get stuck. This leak is now documented and I've tried to make it slightly less bad by adding a one-element buffer to the output channels of the line-reading loop. Should the reader eventually awake from its blocked state (i.e. when stdin is closed), at least it won't get stuck trying to send to the interpreter loop which has quit long ago. Co-authored-by: Felix Lange <fjl@twurst.com>
221 lines
6.3 KiB
Go
221 lines
6.3 KiB
Go
// Copyright 2016 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package rpc
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"net"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestNewID(t *testing.T) {
|
|
hexchars := "0123456789ABCDEFabcdef"
|
|
for i := 0; i < 100; i++ {
|
|
id := string(NewID())
|
|
if !strings.HasPrefix(id, "0x") {
|
|
t.Fatalf("invalid ID prefix, want '0x...', got %s", id)
|
|
}
|
|
|
|
id = id[2:]
|
|
if len(id) == 0 || len(id) > 32 {
|
|
t.Fatalf("invalid ID length, want len(id) > 0 && len(id) <= 32), got %d", len(id))
|
|
}
|
|
|
|
for i := 0; i < len(id); i++ {
|
|
if strings.IndexByte(hexchars, id[i]) == -1 {
|
|
t.Fatalf("unexpected byte, want any valid hex char, got %c", id[i])
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSubscriptions(t *testing.T) {
|
|
var (
|
|
namespaces = []string{"eth", "shh", "bzz"}
|
|
service = ¬ificationTestService{}
|
|
subCount = len(namespaces)
|
|
notificationCount = 3
|
|
|
|
server = NewServer()
|
|
clientConn, serverConn = net.Pipe()
|
|
out = json.NewEncoder(clientConn)
|
|
in = json.NewDecoder(clientConn)
|
|
successes = make(chan subConfirmation)
|
|
notifications = make(chan subscriptionResult)
|
|
errors = make(chan error, subCount*notificationCount+1)
|
|
)
|
|
|
|
// setup and start server
|
|
for _, namespace := range namespaces {
|
|
if err := server.RegisterName(namespace, service); err != nil {
|
|
t.Fatalf("unable to register test service %v", err)
|
|
}
|
|
}
|
|
go server.ServeCodec(NewCodec(serverConn), 0)
|
|
defer server.Stop()
|
|
|
|
// wait for message and write them to the given channels
|
|
go waitForMessages(in, successes, notifications, errors)
|
|
|
|
// create subscriptions one by one
|
|
for i, namespace := range namespaces {
|
|
request := map[string]interface{}{
|
|
"id": i,
|
|
"method": fmt.Sprintf("%s_subscribe", namespace),
|
|
"version": "2.0",
|
|
"params": []interface{}{"someSubscription", notificationCount, i},
|
|
}
|
|
if err := out.Encode(&request); err != nil {
|
|
t.Fatalf("Could not create subscription: %v", err)
|
|
}
|
|
}
|
|
|
|
timeout := time.After(30 * time.Second)
|
|
subids := make(map[string]string, subCount)
|
|
count := make(map[string]int, subCount)
|
|
allReceived := func() bool {
|
|
done := len(count) == subCount
|
|
for _, c := range count {
|
|
if c < notificationCount {
|
|
done = false
|
|
}
|
|
}
|
|
return done
|
|
}
|
|
for !allReceived() {
|
|
select {
|
|
case confirmation := <-successes: // subscription created
|
|
subids[namespaces[confirmation.reqid]] = string(confirmation.subid)
|
|
case notification := <-notifications:
|
|
count[notification.ID]++
|
|
case err := <-errors:
|
|
t.Fatal(err)
|
|
case <-timeout:
|
|
for _, namespace := range namespaces {
|
|
subid, found := subids[namespace]
|
|
if !found {
|
|
t.Errorf("subscription for %q not created", namespace)
|
|
continue
|
|
}
|
|
if count, found := count[subid]; !found || count < notificationCount {
|
|
t.Errorf("didn't receive all notifications (%d<%d) in time for namespace %q", count, notificationCount, namespace)
|
|
}
|
|
}
|
|
t.Fatal("timed out")
|
|
}
|
|
}
|
|
}
|
|
|
|
// This test checks that unsubscribing works.
|
|
func TestServerUnsubscribe(t *testing.T) {
|
|
p1, p2 := net.Pipe()
|
|
defer p2.Close()
|
|
|
|
// Start the server.
|
|
server := newTestServer()
|
|
service := ¬ificationTestService{unsubscribed: make(chan string, 1)}
|
|
server.RegisterName("nftest2", service)
|
|
go server.ServeCodec(NewCodec(p1), 0)
|
|
|
|
// Subscribe.
|
|
p2.SetDeadline(time.Now().Add(10 * time.Second))
|
|
p2.Write([]byte(`{"jsonrpc":"2.0","id":1,"method":"nftest2_subscribe","params":["someSubscription",0,10]}`))
|
|
|
|
// Handle received messages.
|
|
var (
|
|
resps = make(chan subConfirmation)
|
|
notifications = make(chan subscriptionResult)
|
|
errors = make(chan error, 1)
|
|
)
|
|
go waitForMessages(json.NewDecoder(p2), resps, notifications, errors)
|
|
|
|
// Receive the subscription ID.
|
|
var sub subConfirmation
|
|
select {
|
|
case sub = <-resps:
|
|
case err := <-errors:
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Unsubscribe and check that it is handled on the server side.
|
|
p2.Write([]byte(`{"jsonrpc":"2.0","method":"nftest2_unsubscribe","params":["` + sub.subid + `"]}`))
|
|
for {
|
|
select {
|
|
case id := <-service.unsubscribed:
|
|
if id != string(sub.subid) {
|
|
t.Errorf("wrong subscription ID unsubscribed")
|
|
}
|
|
return
|
|
case err := <-errors:
|
|
t.Fatal(err)
|
|
case <-notifications:
|
|
// drop notifications
|
|
}
|
|
}
|
|
}
|
|
|
|
type subConfirmation struct {
|
|
reqid int
|
|
subid ID
|
|
}
|
|
|
|
// waitForMessages reads RPC messages from 'in' and dispatches them into the given channels.
|
|
// It stops if there is an error.
|
|
func waitForMessages(in *json.Decoder, successes chan subConfirmation, notifications chan subscriptionResult, errors chan error) {
|
|
for {
|
|
resp, notification, err := readAndValidateMessage(in)
|
|
if err != nil {
|
|
errors <- err
|
|
return
|
|
} else if resp != nil {
|
|
successes <- *resp
|
|
} else {
|
|
notifications <- *notification
|
|
}
|
|
}
|
|
}
|
|
|
|
func readAndValidateMessage(in *json.Decoder) (*subConfirmation, *subscriptionResult, error) {
|
|
var msg jsonrpcMessage
|
|
if err := in.Decode(&msg); err != nil {
|
|
return nil, nil, fmt.Errorf("decode error: %v", err)
|
|
}
|
|
switch {
|
|
case msg.isNotification():
|
|
var res subscriptionResult
|
|
if err := json.Unmarshal(msg.Params, &res); err != nil {
|
|
return nil, nil, fmt.Errorf("invalid subscription result: %v", err)
|
|
}
|
|
return nil, &res, nil
|
|
case msg.isResponse():
|
|
var c subConfirmation
|
|
if msg.Error != nil {
|
|
return nil, nil, msg.Error
|
|
} else if err := json.Unmarshal(msg.Result, &c.subid); err != nil {
|
|
return nil, nil, fmt.Errorf("invalid response: %v", err)
|
|
} else {
|
|
json.Unmarshal(msg.ID, &c.reqid)
|
|
return &c, nil, nil
|
|
}
|
|
default:
|
|
return nil, nil, fmt.Errorf("unrecognized message: %v", msg)
|
|
}
|
|
}
|