Alex Prut
810f9e057d
all: remove redundant conversions and import names ( #21903 )
2020-11-25 21:00:23 +01:00
mr_franklin
66c3eb2f1a
accouts, consensus, core: fix some comments ( #21617 )
2020-10-12 15:02:38 +02:00
Martin Michlmayr
4f2784b38f
all: fix typos in comments ( #21118 )
2020-05-25 10:21:28 +02:00
Felix Lange
c8e9a91672
build: upgrade to golangci-lint 1.24.0 ( #20901 )
...
* accounts/scwallet: remove unnecessary uses of fmt.Sprintf
* cmd/puppeth: remove unnecessary uses of fmt.Sprintf
* p2p/discv5: remove unnecessary use of fmt.Sprintf
* whisper/mailserver: remove unnecessary uses of fmt.Sprintf
* core: goimports -w tx_pool_test.go
* eth/downloader: goimports -w downloader_test.go
* build: upgrade to golangci-lint 1.24.0
2020-04-08 11:07:29 +03:00
Guillaume Ballet
54d332e1db
accounts/scwallet: fix staticcheck warnings ( #20370 )
2019-11-29 11:42:53 +01:00
Guillaume Ballet
7a22da98b9
accounts/scwallet: flag to specify path to smartcard daemon ( #19439 )
...
* accounts/scwallet: Add a switch to enable smartcard support
* accounts: change the meaning of the switch
* disable card support in windows until tested
* only activate account if pcscd socket file is present
* the switch is now the path to the socket file
* accounts/scwallet: holiman's review feedback
* accounts/scwallet: send the path to go-pcsclite
* accounts/scwallet: add default, per platform path
* accounts/scwallet: fix error log warning
* accounts/scwallet: update pcsc lib to latest
* accounts/scwallet: use default path from pcsclite
* scwallet: forgot to change switch name
* cmd: minor style cleanups (error handling first, then happy path)
2019-05-31 12:30:28 +03:00
Guillaume Ballet
048df258dc
accounts/scwallet: change sc url scheme to keycard ( #19632 )
2019-05-28 19:47:53 +03:00
Péter Szilágyi
7bc1cb3677
accounts/scwallet: fix public key confirmation regression
2019-05-27 17:29:02 +03:00
Guillaume Ballet
75a860880c
accounts/scwallet: display PUK retry count, validate PIN/PUK length
2019-05-27 17:29:01 +03:00
Martin Holst Swende
fec3b56f7f
accounts, p2p, rpc: make CGO_ENABLED=0 build again ( #19593 )
...
* p2p: remove direct import of cgo-library
* accounts, rpc: more nocgo alternatives
* rpc: move unix path constant into separate file
* accounts/scwallet: address review concerns, remove copy-pasta
2019-05-26 01:07:10 +03:00
Péter Szilágyi
7c91038bff
Merge pull request #19438 from karalabe/ledger-new-derivation-path
...
accounts: switch Ledger derivation path to canonical one
2019-04-25 13:33:17 +03:00
Guillaume Ballet
a1c5017bc5
accounts/scwallet: fix card pairing instruction message ( #19436 )
2019-04-10 13:46:35 +03:00
Péter Szilágyi
ae7344d799
accounts: switch Ledger derivation path to canonical one
2019-04-10 13:09:08 +03:00
Péter Szilágyi
8cf764da89
Revert "Can now specify the number of empty accounts to derive"
...
This reverts commit 5b30aa59d6
.
2019-04-10 12:51:22 +03:00
Guillaume Ballet
f0b878d56d
accounts/scwallet: Update README for v2.2.1 support ( #19425 )
...
Update the app download link to the latest version, as requested in #19418
2019-04-10 10:51:45 +02:00
Guillaume Ballet
5b30aa59d6
Can now specify the number of empty accounts to derive
2019-04-08 13:21:22 +02:00
Guillaume Ballet
6f21520a82
More review feedback
2019-04-08 13:21:22 +02:00
Guillaume Ballet
fc3000d649
more review feedback
2019-04-08 13:21:22 +02:00
Martin Holst Swende
aae61ab16e
Apply suggestions from code review
...
Co-Authored-By: gballet <gballet@gmail.com>
2019-04-08 13:21:22 +02:00
Guillaume Ballet
3b3e1bc07e
Update the card preparation instructions based on review feedback
2019-04-08 13:21:22 +02:00
Guillaume Ballet
8c786a1f99
refresh the account list when initializing the card
2019-04-08 13:21:22 +02:00
Guillaume Ballet
79f4cfac2e
refuse to overwrite the master key of a previously initialized card
2019-04-08 13:21:22 +02:00
Guillaume Ballet
1d1bee528e
fix unnecessary condition linter warning
2019-04-08 13:21:22 +02:00
Guillaume Ballet
714675cd2a
Upgrade to keycard app v2.1.1
2019-04-08 13:21:22 +02:00
Guillaume Ballet
35b80f1865
Fix linter issues
2019-04-08 13:21:22 +02:00
Guillaume Ballet
bcf3c52ac9
PK derivation has to be supported by the card
2019-04-08 13:21:22 +02:00
Guillaume Ballet
189a032987
Add instructions on how to install the card
2019-04-08 13:21:22 +02:00
Guillaume Ballet
ec4fba83d4
Formatting fixes
2019-04-08 13:21:22 +02:00
Guillaume Ballet
21b01f590d
Update a comment to reflect the workings of the updated system
2019-04-08 13:21:22 +02:00
Guillaume Ballet
9b66a8520a
Add some documentation
2019-04-08 13:21:22 +02:00
Guillaume Ballet
e273031dce
Fix key derivation
2019-04-08 13:21:22 +02:00
Guillaume Ballet
7ec6fa03d3
fix wallet status update
...
This is a temporary fix, better checks need to
be performed once the whole process has been
validated.
2019-04-08 13:21:22 +02:00
Guillaume Ballet
42c76a2ba1
Temporary fix to the ADBU status call
2019-04-08 13:21:22 +02:00
Guillaume Ballet
5617dca1c9
Remove the direct dependency on libpcsclite
...
Instead, use a go library that communicates with pcscd over a socket.
Also update the changes introduced by @gravityblast since this PR's
inception
2019-04-08 13:21:22 +02:00
Guillaume Ballet
ae82c58631
Fix some linter issues
2019-04-08 13:19:37 +02:00
Guillaume Ballet
7b230b7ef1
accounts/scwallet: rebase and update
2019-04-08 13:19:37 +02:00
Péter Szilágyi
a900e80a89
accounts/scwallet: fix crypto API change
2019-04-08 13:19:37 +02:00
Péter Szilágyi
7d5886dcf4
accounts, console: frendly card errors, support pin unblock
2019-04-08 13:19:37 +02:00
Péter Szilágyi
386943943f
accounts/scwallet: ordered wallets, tighter events, derivation logs
2019-04-08 13:19:37 +02:00
Péter Szilágyi
114de0fe2a
accounts/scwallet, console: user friendly card opening
2019-04-08 13:19:37 +02:00
Nick Johnson
78375608a4
accounts, internal: Changes in response to review
2019-04-08 13:19:37 +02:00
Nick Johnson
f7027dd68c
accounts, core, internal, node: Add support for smartcard wallets
2019-04-08 13:19:37 +02:00