cerc-io/plugeth
18
0
Fork 1
Code Issues 4 Pull Requests Packages Projects Releases Wiki Activity

eth/downloader: fix mutex regression causing panics on fail (#3591)

Browse Source
This commit is contained in:
Péter Szilágyi 2017-01-20 02:12:14 +02:00 committed by Felix Lange
parent f087c66f95
commit ebc3d232f4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
eth/downloader/queue.go
View File

@ -1129,12 +1129,13 @@ func (q *queue) deliverNodeData(results []trie.SyncResult, callback func(int, bo
if err != nil { if err != nil {
q.stateSchedLock.Unlock() q.stateSchedLock.Unlock()
callback(i, progressed, err) callback(i, progressed, err)
return
} }
if err = batch.Write(); err != nil { if err = batch.Write(); err != nil {
q.stateSchedLock.Unlock() q.stateSchedLock.Unlock()
callback(i, progressed, err) callback(i, progressed, err)
return // TODO(karalabe): If a DB write fails (disk full), we ought to cancel the sync
} }
// Item processing succeeded, release the lock (temporarily) // Item processing succeeded, release the lock (temporarily)
progressed = progressed || prog progressed = progressed || prog
q.stateSchedLock.Unlock() q.stateSchedLock.Unlock()