cmd/utils: fix --password on Windows

Text files created on Windows typically have \r\n line endings.
Trim them when reading password files.
This commit is contained in:
Felix Lange 2016-03-30 23:20:06 +02:00
parent aca9d6a1fb
commit ea005a0295

View File

@ -606,17 +606,22 @@ func MakeMinerExtra(extra []byte, ctx *cli.Context) []byte {
return extra return extra
} }
// MakePasswordList loads up a list of password from a file specified by the // MakePasswordList reads password lines from the file specified by --password.
// command line flags.
func MakePasswordList(ctx *cli.Context) []string { func MakePasswordList(ctx *cli.Context) []string {
if path := ctx.GlobalString(PasswordFileFlag.Name); path != "" { path := ctx.GlobalString(PasswordFileFlag.Name)
blob, err := ioutil.ReadFile(path) if path == "" {
return nil
}
text, err := ioutil.ReadFile(path)
if err != nil { if err != nil {
Fatalf("Failed to read password file: %v", err) Fatalf("Failed to read password file: %v", err)
} }
return strings.Split(string(blob), "\n") lines := strings.Split(string(text), "\n")
// Sanitise DOS line endings.
for i := range lines {
lines[i] = strings.TrimRight(lines[i], "\r")
} }
return nil return lines
} }
// MakeSystemNode sets up a local node, configures the services to launch and // MakeSystemNode sets up a local node, configures the services to launch and