log: avoid setting default slog logger in init (#28747)

slog.SetDefault has undesirable side effects. It also sets the default logger destination,
for example. So we should not call it by default in init.
This commit is contained in:
Felix Lange 2023-12-30 21:16:02 +01:00 committed by GitHub
parent 76a5474b32
commit c053eb71b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -10,8 +10,7 @@ import (
var root atomic.Value
func init() {
defaultLogger := &logger{slog.New(DiscardHandler())}
SetDefault(defaultLogger)
root.Store(&logger{slog.New(DiscardHandler())})
}
// SetDefault sets the default global logger