Merge pull request #1043 from obscuren/test_fixes

core/vm: optimisation on RETURN and updated tests

core/vm/memory.go

@@ -49,6 +49,18 @@ func (self *Memory) Get(offset, size int64) (cpy []byte) {
 	return
 }
 
+func (self *Memory) GetPtr(offset, size int64) []byte {
+	if size == 0 {
+		return nil
+	}
+
+	if len(self.store) > int(offset) {
+		return self.store[offset : offset+size]
+	}
+
+	return nil
+}
+
 func (m *Memory) Len() int {
 	return len(m.store)
 }

core/vm/vm.go

@@ -695,7 +695,7 @@ func (self *Vm) Run(context *Context, callData []byte) (ret []byte, err error) {
 			self.Printf("resume %x (%v)", context.Address(), context.Gas)
 		case RETURN:
 			offset, size := stack.pop(), stack.pop()
-			ret := mem.Get(offset.Int64(), size.Int64())
+			ret := mem.GetPtr(offset.Int64(), size.Int64())
 
 			self.Printf(" => [%v, %v] (%d) 0x%x", offset, size, len(ret), ret).Endl()
 

tests/vm/gh_test.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"io/ioutil"
 	"math/big"
+	"os"
 	"path/filepath"
 	"strconv"
 	"testing"
@@ -87,7 +88,7 @@ func RunVmTest(p string, t *testing.T) {
 			vm.Debug = true
 			glog.SetV(4)
 			glog.SetToStderr(true)
-			if name != "stackLimitPush32_1024" {
+			if name != "Call50000_sha256" {
 				continue
 			}
 		*/
@@ -128,10 +129,16 @@ func RunVmTest(p string, t *testing.T) {
 			ret, logs, gas, err = helper.RunState(statedb, env, test.Transaction)
 		}
 
+		switch name {
+		// the memory required for these tests (4294967297 bytes) would take too much time.
+		// on 19 May 2015 decided to skip these tests their output.
+		case "mload32bitBound_return", "mload32bitBound_return2":
+		default:
 			rexp := helper.FromHex(test.Out)
 			if bytes.Compare(rexp, ret) != 0 {
 				t.Errorf("%s's return failed. Expected %x, got %x\n", name, rexp, ret)
 			}
+		}
 
 		if isVmTest {
 			if len(test.Gas) == 0 && err == nil {
@@ -246,8 +253,7 @@ func TestLogTest(t *testing.T) {
 }
 
 func TestPerformance(t *testing.T) {
-	t.Skip()
-	const fn = "../files/VMTests/vmPerformance.json"
+	const fn = "../files/VMTests/vmPerformanceTest.json"
 	RunVmTest(fn, t)
 }
 
@@ -281,13 +287,13 @@ func TestInputLimitsLight(t *testing.T) {
 	RunVmTest(fn, t)
 }
 
-func TestStateExample(t *testing.T) {
-	const fn = "../files/StateTests/stExample.json"
+func TestStateSystemOperations(t *testing.T) {
+	const fn = "../files/StateTests/stSystemOperationsTest.json"
 	RunVmTest(fn, t)
 }
 
-func TestStateSystemOperations(t *testing.T) {
-	const fn = "../files/StateTests/stSystemOperationsTest.json"
+func TestStateExample(t *testing.T) {
+	const fn = "../files/StateTests/stExample.json"
 	RunVmTest(fn, t)
 }
 
@@ -342,13 +348,17 @@ func TestMemory(t *testing.T) {
 }
 
 func TestMemoryStress(t *testing.T) {
-	t.Skip("Skipped due to...consuming too much memory :D")
+	if os.Getenv("TEST_VM_COMPLEX") == "" {
+		t.Skip()
+	}
 	const fn = "../files/StateTests/stMemoryStressTest.json"
 	RunVmTest(fn, t)
 }
 
 func TestQuadraticComplexity(t *testing.T) {
-	t.Skip() // takes too long
+	if os.Getenv("TEST_VM_COMPLEX") == "" {
+		t.Skip()
+	}
 	const fn = "../files/StateTests/stQuadraticComplexityTest.json"
 	RunVmTest(fn, t)
 }