From 96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jano=C5=A1=20Gulja=C5=A1?= Date: Wed, 16 Jan 2019 12:56:34 +0100 Subject: [PATCH] swarm/network: fix data race in TestNetworkID test (#18460) --- swarm/network/networkid_test.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/swarm/network/networkid_test.go b/swarm/network/networkid_test.go index 99890118f..8e68e5b52 100644 --- a/swarm/network/networkid_test.go +++ b/swarm/network/networkid_test.go @@ -76,13 +76,12 @@ func TestNetworkID(t *testing.T) { if err != nil { t.Fatalf("Error setting up network: %v", err) } - defer func() { - //shutdown the snapshot network - log.Trace("Shutting down network") - net.Shutdown() - }() //let's sleep to ensure all nodes are connected time.Sleep(1 * time.Second) + // shutdown the the network to avoid race conditions + // on accessing kademlias global map while network nodes + // are accepting messages + net.Shutdown() //for each group sharing the same network ID... for _, netIDGroup := range nodeMap { log.Trace("netIDGroup size", "size", len(netIDGroup))