cerc-io/plugeth
18
0
Fork 1
Code Issues 4 Pull Requests Packages Projects Releases Wiki Activity

p2p/discover: fix a race where table loop would self-lookup before returning from constructor

Browse Source
This commit is contained in:
Martin Holst Swende 2019-05-13 11:25:54 +02:00
parent abeba0a1de
commit 95263914fc
No known key found for this signature in database
GPG Key ID: 683B438C05A5DDF0
3 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
p2p/discover/table.go
View File

@ -119,7 +119,6 @@ func newTable(t transport, db *enode.DB, bootnodes []*enode.Node, log log.Logger
tab.seedRand() tab.seedRand()
tab.loadSeedNodes() tab.loadSeedNodes()
go tab.loop()
return tab, nil return tab, nil
} }

1
p2p/discover/table_util_test.go
View File

@ -42,6 +42,7 @@ func init() {
func newTestTable(t transport) (*Table, *enode.DB) { func newTestTable(t transport) (*Table, *enode.DB) {
db, _ := enode.OpenDB("") db, _ := enode.OpenDB("")
tab, _ := newTable(t, db, nil, log.Root()) tab, _ := newTable(t, db, nil, log.Root())
go tab.loop()
return tab, db return tab, db
} }

1
p2p/discover/v4_udp.go
View File

@ -253,6 +253,7 @@ func ListenV4(c UDPConn, ln *enode.LocalNode, cfg Config) (*UDPv4, error) {
return nil, err return nil, err
} }
t.tab = tab t.tab = tab
go tab.loop()
t.wg.Add(2) t.wg.Add(2)
go t.loop() go t.loop()