From 004ed786b424ef3d6491ce46c3d893d8ecac3cc2 Mon Sep 17 00:00:00 2001 From: Gustav Simonsson Date: Tue, 8 Sep 2015 15:53:17 +0200 Subject: [PATCH 1/2] core/state: deleted field in StateObject Copy() and unit test --- core/state/state_object.go | 1 + core/state/state_test.go | 104 +++++++++++++++++++++++++++++++++++++ 2 files changed, 105 insertions(+) diff --git a/core/state/state_object.go b/core/state/state_object.go index c76feb774..0af0fbd5a 100644 --- a/core/state/state_object.go +++ b/core/state/state_object.go @@ -263,6 +263,7 @@ func (self *StateObject) Copy() *StateObject { stateObject.gasPool.Set(self.gasPool) stateObject.remove = self.remove stateObject.dirty = self.dirty + stateObject.deleted = self.deleted return stateObject } diff --git a/core/state/state_test.go b/core/state/state_test.go index 5972d266a..35cf53e3e 100644 --- a/core/state/state_test.go +++ b/core/state/state_test.go @@ -17,6 +17,7 @@ package state import ( + "bytes" "math/big" "testing" @@ -117,3 +118,106 @@ func (s *StateSuite) TestSnapshot(c *checker.C) { c.Assert(data1, checker.DeepEquals, res) } + +// use testing instead of checker because checker does not support +// printing/logging in tests (-check.vv does not work) +func TestSnapshot2(t *testing.T) { + db, _ := ethdb.NewMemDatabase() + state := New(common.Hash{}, db) + + stateobjaddr0 := toAddr([]byte("so0")) + stateobjaddr1 := toAddr([]byte("so1")) + var storageaddr common.Hash + + data0 := common.BytesToHash([]byte{17}) + data1 := common.BytesToHash([]byte{18}) + + state.SetState(stateobjaddr0, storageaddr, data0) + state.SetState(stateobjaddr1, storageaddr, data1) + + // db, trie are already non-empty values + so0 := state.GetStateObject(stateobjaddr0) + so0.balance = big.NewInt(42) + so0.nonce = 43 + so0.gasPool = big.NewInt(44) + so0.code = []byte{'c', 'a', 'f', 'e'} + so0.codeHash = so0.CodeHash() + so0.remove = true + so0.deleted = false + so0.dirty = false + state.SetStateObject(so0) + + // and one with deleted == true + so1 := state.GetStateObject(stateobjaddr1) + so1.balance = big.NewInt(52) + so1.nonce = 53 + so1.gasPool = big.NewInt(54) + so1.code = []byte{'c', 'a', 'f', 'e', '2'} + so1.codeHash = so1.CodeHash() + so1.remove = true + so1.deleted = true + so1.dirty = true + state.SetStateObject(so1) + + so1 = state.GetStateObject(stateobjaddr1) + if so1 != nil { + t.Fatalf("deleted object not nil when getting") + } + + snapshot := state.Copy() + state.Set(snapshot) + + so0Restored := state.GetStateObject(stateobjaddr0) + so1Restored := state.GetStateObject(stateobjaddr1) + // non-deleted is equal (restored) + compareStateObjects(so0, so0Restored, t) + // deleted should be nil, both before and after restore of state copy + if so1Restored != nil { + t.Fatalf("deleted object not nil after restoring snapshot") + } +} + +func compareStateObjects(so0, so1 *StateObject, t *testing.T) { + if so0.address != so1.address { + t.Fatalf("\nexpected %v\ngot %v", so0.address, so1.address) + } + if so0.balance.Cmp(so1.balance) != 0 { + t.Fatalf("\nexpected %v\ngot %v", so0.balance, so1.balance) + } + if so0.nonce != so1.nonce { + t.Fatalf("\nexpected %v\ngot %v", so0.nonce, so1.nonce) + } + if !bytes.Equal(so0.codeHash, so1.codeHash) { + t.Fatalf("\nexpected %v\ngot %v", so0.codeHash, so1.codeHash) + } + if !bytes.Equal(so0.code, so1.code) { + t.Fatalf("\nexpected %v\ngot %v", so0.code, so1.code) + } + if !bytes.Equal(so0.initCode, so1.initCode) { + t.Fatalf("\nexpected %v\ngot %v", so0.initCode, so1.initCode) + } + + for k, v := range so0.storage { + if so1.storage[k] != v { + t.Fatalf("\nstorage key %s:\nexpected %v\ngot %v", k, v, so1.storage[k]) + } + } + for k, v := range so1.storage { + if so0.storage[k] != v { + t.Fatalf("\nunexpected k,v : %v, %v", k, v) + } + } + + if so0.gasPool.Cmp(so1.gasPool) != 0 { + t.Fatalf("\nexpected %v\ngot %v", so0.gasPool, so1.gasPool) + } + if so0.remove != so1.remove { + t.Fatalf("\nexpected %v\ngot %v", so0.remove, so1.remove) + } + if so0.deleted != so1.deleted { + t.Fatalf("\nexpected %v\ngot %v", so0.deleted, so1.deleted) + } + if so0.dirty != so1.dirty { + t.Fatalf("\nexpected %v\ngot %v", so0.dirty, so1.dirty) + } +} From bf879ef230b33f3cff4c075c205dbaeb8f09d820 Mon Sep 17 00:00:00 2001 From: Gustav Simonsson Date: Wed, 9 Sep 2015 00:26:18 +0200 Subject: [PATCH 2/2] core/state: test formatting adhering to Go convention --- core/state/state_test.go | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/core/state/state_test.go b/core/state/state_test.go index 35cf53e3e..60836738e 100644 --- a/core/state/state_test.go +++ b/core/state/state_test.go @@ -170,7 +170,7 @@ func TestSnapshot2(t *testing.T) { so0Restored := state.GetStateObject(stateobjaddr0) so1Restored := state.GetStateObject(stateobjaddr1) // non-deleted is equal (restored) - compareStateObjects(so0, so0Restored, t) + compareStateObjects(so0Restored, so0, t) // deleted should be nil, both before and after restore of state copy if so1Restored != nil { t.Fatalf("deleted object not nil after restoring snapshot") @@ -179,45 +179,45 @@ func TestSnapshot2(t *testing.T) { func compareStateObjects(so0, so1 *StateObject, t *testing.T) { if so0.address != so1.address { - t.Fatalf("\nexpected %v\ngot %v", so0.address, so1.address) + t.Fatalf("Address mismatch: have %v, want %v", so0.address, so1.address) } if so0.balance.Cmp(so1.balance) != 0 { - t.Fatalf("\nexpected %v\ngot %v", so0.balance, so1.balance) + t.Fatalf("Balance mismatch: have %v, want %v", so0.balance, so1.balance) } if so0.nonce != so1.nonce { - t.Fatalf("\nexpected %v\ngot %v", so0.nonce, so1.nonce) + t.Fatalf("Nonce mismatch: have %v, want %v", so0.nonce, so1.nonce) } if !bytes.Equal(so0.codeHash, so1.codeHash) { - t.Fatalf("\nexpected %v\ngot %v", so0.codeHash, so1.codeHash) + t.Fatalf("CodeHash mismatch: have %v, want %v", so0.codeHash, so1.codeHash) } if !bytes.Equal(so0.code, so1.code) { - t.Fatalf("\nexpected %v\ngot %v", so0.code, so1.code) + t.Fatalf("Code mismatch: have %v, want %v", so0.code, so1.code) } if !bytes.Equal(so0.initCode, so1.initCode) { - t.Fatalf("\nexpected %v\ngot %v", so0.initCode, so1.initCode) + t.Fatalf("InitCode mismatch: have %v, want %v", so0.initCode, so1.initCode) } - for k, v := range so0.storage { - if so1.storage[k] != v { - t.Fatalf("\nstorage key %s:\nexpected %v\ngot %v", k, v, so1.storage[k]) - } - } for k, v := range so1.storage { if so0.storage[k] != v { - t.Fatalf("\nunexpected k,v : %v, %v", k, v) + t.Fatalf("Storage key %s mismatch: have %v, want %v", k, so0.storage[k], v) + } + } + for k, v := range so0.storage { + if so1.storage[k] != v { + t.Fatalf("Storage key %s mismatch: have %v, want none.", k, v) } } if so0.gasPool.Cmp(so1.gasPool) != 0 { - t.Fatalf("\nexpected %v\ngot %v", so0.gasPool, so1.gasPool) + t.Fatalf("GasPool mismatch: have %v, want %v", so0.gasPool, so1.gasPool) } if so0.remove != so1.remove { - t.Fatalf("\nexpected %v\ngot %v", so0.remove, so1.remove) + t.Fatalf("Remove mismatch: have %v, want %v", so0.remove, so1.remove) } if so0.deleted != so1.deleted { - t.Fatalf("\nexpected %v\ngot %v", so0.deleted, so1.deleted) + t.Fatalf("Deleted mismatch: have %v, want %v", so0.deleted, so1.deleted) } if so0.dirty != so1.dirty { - t.Fatalf("\nexpected %v\ngot %v", so0.dirty, so1.dirty) + t.Fatalf("Dirty mismatch: have %v, want %v", so0.dirty, so1.dirty) } }