p2p: fix rare deadlock in Stop (#17260)

This commit is contained in:
Janoš Guljaš 2018-07-30 11:44:17 +02:00 committed by Péter Szilágyi
parent d42ce0f2c1
commit 8f4c4fea20

View File

@ -340,8 +340,8 @@ func (srv *Server) makeSelf(listener net.Listener, ntab discoverTable) *discover
// It blocks until all active connections have been closed.
func (srv *Server) Stop() {
srv.lock.Lock()
defer srv.lock.Unlock()
if !srv.running {
srv.lock.Unlock()
return
}
srv.running = false
@ -350,6 +350,7 @@ func (srv *Server) Stop() {
srv.listener.Close()
}
close(srv.quit)
srv.lock.Unlock()
srv.loopWG.Wait()
}