cerc-io/plugeth
18
0
Fork 1
Code Issues 4 Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1534 from obscuren/issue-1040

Browse Source 
rpc: to in eth_call no longer required. Fixed eth_estimateGas
This commit is contained in:
Jeffrey Wilcke 2015-07-30 03:25:47 -07:00
commit 64e2f52c2e
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rpc/api/args_test.go
View File

@ -935,9 +935,9 @@ func TestCallArgsNotStrings(t *testing.T) {
func TestCallArgsToEmpty(t *testing.T) { func TestCallArgsToEmpty(t *testing.T) {
input := `[{"from": "0xb60e8dd61c5d32be8058bb8eb970870f07233155"}]` input := `[{"from": "0xb60e8dd61c5d32be8058bb8eb970870f07233155"}]`
args := new(CallArgs) args := new(CallArgs)
str := ExpectValidationError(json.Unmarshal([]byte(input), &args)) err := json.Unmarshal([]byte(input), &args)
if len(str) > 0 { if err != nil {
t.Error(str) t.Error("Did not expect error. Got", err)
} }
} }

2
rpc/api/eth.go
View File

@ -322,7 +322,7 @@ func (self *ethApi) EstimateGas(req *shared.Request) (interface{}, error) {
if len(gas) == 0 { if len(gas) == 0 {
return newHexNum(0), nil return newHexNum(0), nil
} else { } else {
return newHexNum(gas), nil return newHexNum(common.String2Big(gas)), err
} }
} }

4
rpc/api/eth_args.go
View File

@ -469,10 +469,6 @@ func (args *CallArgs) UnmarshalJSON(b []byte) (err error) {
} }
args.From = ext.From args.From = ext.From
if len(ext.To) == 0 {
return shared.NewValidationError("to", "is required")
}
args.To = ext.To args.To = ext.To
var num *big.Int var num *big.Int