added IPC timeout support

rpc/codec/json.go

@@ -10,6 +10,7 @@ import (
 )
 
 const (
+	READ_TIMEOUT      = 15 // read timeout in seconds
 	MAX_REQUEST_SIZE  = 1024 * 1024
 	MAX_RESPONSE_SIZE = 1024 * 1024
 )
@@ -17,54 +18,61 @@ const (
 // Json serialization support
 type JsonCodec struct {
 	c net.Conn
-	buffer        []byte
-	bytesInBuffer int
 }
 
 // Create new JSON coder instance
 func NewJsonCoder(conn net.Conn) ApiCoder {
 	return &JsonCodec{
 		c: conn,
-		buffer:        make([]byte, MAX_REQUEST_SIZE),
-		bytesInBuffer: 0,
 	}
 }
 
 // Serialize obj to JSON and write it to conn
 func (self *JsonCodec) ReadRequest() (requests []*shared.Request, isBatch bool, err error) {
-	n, err := self.c.Read(self.buffer[self.bytesInBuffer:])
+	bytesInBuffer := 0
-	if err != nil {
+	buf := make([]byte, MAX_REQUEST_SIZE)
-		self.bytesInBuffer = 0
+
+	deadline := time.Now().Add(READ_TIMEOUT * time.Second)
+	if err := self.c.SetDeadline(deadline); err != nil {
 		return nil, false, err
 	}
 
-	self.bytesInBuffer += n
+	for {
+		n, err := self.c.Read(buf[bytesInBuffer:])
+		if err != nil {
+			self.c.Close()
+			return nil, false, err
+		}
+
+		bytesInBuffer += n
 
 		singleRequest := shared.Request{}
-	err = json.Unmarshal(self.buffer[:self.bytesInBuffer], &singleRequest)
+		err = json.Unmarshal(buf[:bytesInBuffer], &singleRequest)
 		if err == nil {
-		self.bytesInBuffer = 0
 			requests := make([]*shared.Request, 1)
 			requests[0] = &singleRequest
 			return requests, false, nil
 		}
 
 		requests = make([]*shared.Request, 0)
-	err = json.Unmarshal(self.buffer[:self.bytesInBuffer], &requests)
+		err = json.Unmarshal(buf[:bytesInBuffer], &requests)
 		if err == nil {
-		self.bytesInBuffer = 0
 			return requests, true, nil
 		}
+	}
 
-	return nil, false, err
+	self.c.Close() // timeout
+	return nil, false, fmt.Errorf("Unable to read response")
 }
 
 func (self *JsonCodec) ReadResponse() (interface{}, error) {
 	bytesInBuffer := 0
 	buf := make([]byte, MAX_RESPONSE_SIZE)
 
-	deadline := time.Now().Add(15 * time.Second)
+	deadline := time.Now().Add(READ_TIMEOUT * time.Second)
-	self.c.SetDeadline(deadline)
+	if err := self.c.SetDeadline(deadline); err != nil {
+		return nil, err
+	}
 
 	for {
 		n, err := self.c.Read(buf[bytesInBuffer:])